Hide Forgot
Created attachment 359900 [details] Spec file patch bcprov.jar is missing a couple of .properties files and includes test suite classes in deviation from upstream shipped bcprov jar. Fix for these and some other packaging issues/improvements attached; these would be nice to have in earlier distro versions besides F-12 as well. * Sun Sep 6 2009 Ville Skyttä <ville.skytta@iki.fi> - 1.43-6 - Include missing properties files in jar. - Build with javac -encoding UTF-8. - Use %javac and %jar macros. - Run test suite during build (ignoring failures for now). - Follow upstream in excluding various test suite classes from jar; drop dependency on junit4. I suspect at least some of the test suite failures might be due to missing test data files, but didn't look further.
Hi Ville, What about other bouncycastle packages? bouncycastle-{mail,tsp}? Do they need to be changed too? Do you want to do the changes yourself or do you need me to do them?
(In reply to comment #1) > What about other bouncycastle packages? bouncycastle-{mail,tsp}? Do they need > to be changed too? I don't know - I haven't looked at the contents of {mail,tsp}. Let me know if you'd like me to have a look and compare with upstream. > Do you want to do the changes yourself or do you need me to do them? I took this as an ack for the changes and went ahead and committed this for devel, build is in progress too. It could be better if you'd take care of earlier distro versions as you see fit so you'll get to decide the release tag scheme and spec branching (as the Rawhide one requires later java than what's available on earlier distros, spec file will probably need branching and release tags should probably differ as well to avoid confusion). http://koji.fedoraproject.org/koji/taskinfo?taskID=1658931
I applied the same fixes to {mail,tsp} and built them on F-12. I also applied the fixes to the F-11 packages. I am not doing the F-10 for the time being. F-10 uses bouncycastle-1.41 and one needs some decent spare time to update the packages properly and to test them. If we get a user complaint, we can return to this. Meanwhile, if you (or anyone else) want to do the F-10 updates, be my guest.
bouncycastle-tsp-1.43-6.fc11,bouncycastle-mail-1.43-5.fc11,bouncycastle-1.43-6.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/bouncycastle-tsp-1.43-6.fc11,bouncycastle-mail-1.43-5.fc11,bouncycastle-1.43-6.fc11
bouncycastle-tsp-1.43-6.fc11, bouncycastle-mail-1.43-5.fc11, bouncycastle-1.43-6.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.