Bug 521639 - Review Request: hercstudio - GUI for Hercules
Summary: Review Request: hercstudio - GUI for Hercules
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Martin Gieseking
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-09-07 11:45 UTC by Dan Horák
Modified: 2009-09-17 12:31 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-17 12:31:57 UTC
Type: ---
Embargoed:
martin.gieseking: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Dan Horák 2009-09-07 11:45:06 UTC
Spec URL: http://fedora.danny.cz/hercstudio.spec
SRPM URL: http://fedora.danny.cz/hercstudio-1.0-0.1.beta.fc12.src.rpm

Description:
GUI front-end to the Hercules mainframe Emulator.

Notes:
Rebuilt Hercules packages with external GUI support are sitting in Bodhi (http://admin.fedoraproject.org/updates/search/hercules).

Comment 1 Dan Horák 2009-09-07 20:02:13 UTC
Spec URL: http://fedora.danny.cz/hercstudio.spec
SRPM URL: http://fedora.danny.cz/hercstudio-1.0-0.2.beta.fc12.src.rpm

ChangeLog:
- added patch from upstream to fix behaviour of the buttons in panel
- made the dependency on Hercules versioned

Comment 2 Martin Gieseking 2009-09-15 12:30:41 UTC
Could you upload the files again? The above URLs are invalid.

Comment 3 Dan Horák 2009-09-15 13:20:25 UTC
(In reply to comment #2)
> Could you upload the files again? The above URLs are invalid.  

Please try them later (1 hour later should be enough), my webhosting company silently changed the IP addresses ...

temporary place for SRPM: http://sharkcz.fedorapeople.org/review/hercstudio-1.0-0.2.beta.fc10.src.rpm

Comment 4 Martin Gieseking 2009-09-15 16:54:38 UTC
OK, thanks. I will do the review.

Comment 5 Martin Gieseking 2009-09-15 19:25:47 UTC
The build requires hercules >= 3.06-4 which is not available yet. Are you planning to create another hercules release? 

I wasn't able to run hercules-3.0.6-3 in HerculesStudio (see below) but maybe I simply missed a configuration setting, as I'm not familiar with hercules and its configuration. :) It works on the command-line though.

The package itself is set up properly. I couldn't find anything to be corrected.


$ rpmlint /var/lib/mock/fedora-11-x86_64/result/hercstudio-*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.


---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.

[+] MUST: The spec file name must match the base package %{name}.

[+] MUST: The package must meet the Packaging Guidelines.

[+] MUST: The package must be licensed with a Fedora approved license.
    - GPLv3+ according to the source file headers
    - COPYING contains GPLv3 license text

[+] MUST: The License field in the package spec file must match the actual license.

[+] MUST: COPYING must be included in %doc.

[+] MUST: The spec file must be written in American English.

[+] MUST: The spec file for the package MUST be legible.

[+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL.
    - md5 hash of the tarball I've checked out doesn't match those of the
      tarball in the src rpm. However, the content of both files is identical
     (checked with hg diff)

[+] MUST: The package MUST successfully compile and build into binary rpms.
    koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1681013

[.] MUST: If the package does not successfully compile, ...

[+] MUST: All build dependencies must be listed in BuildRequires. 

[.] MUST: The spec file MUST handle locales properly. 
    - no locales

[.] MUST: Packages containing shared library files must call ldconfig in %post and %postun.
    - no shared libs

[.] MUST: If the package is designed to be relocatable, ...
    - package not relocatable

[.] MUST: A package must own all directories that it creates.
    - doesn't create directories    

[+] MUST: File must not be listed more than once in %files.

[+] MUST: Permissions on files must be set properly.

[+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot}.

[+] MUST: Each package must consistently use macros.

[+] MUST: The package must contain code, or permissable content.

[.] MUST: Large documentation files must go in a -doc subpackage.
    - no large docs

[+] MUST: If a package includes something as %doc, it must not affect the runtime of the application.
    - %doc only contains file COPYING

[.] MUST: Header files must be in a -devel package.
    - no header files packaged

[.] MUST: Static libraries must be in a -static package.
    - no static libs

[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
    - no pkgconfig files

[.] MUST: .so (without suffix) must go in a -devel package.
    - no shared libs

[.] MUST: devel packages must require the base package using a fully versioned dependency
    - no devel subpackage

[.] MUST: Packages must NOT contain any .la libtool archives.
    - no .la files

[+] MUST: Packages containing GUI applications must include a %{name}.desktop file.
    - hercstudio.desktop added as %Source1
    - .desktop file is valid 
    - .desktop file is properly installed with desktop-file-install

[+] MUST: Packages must not own files or directories already owned by other packages.

[+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).

[+] MUST: All filenames in rpm packages must be valid UTF-8.


[+] SHOULD: The reviewer should test that the package builds in mock.
    - builds in mock 

[+] SHOULD: The package should compile and build into binary rpms on all supported architectures.
    - koji scratch build successful (see above)    

[+] SHOULD: The reviewer should test that the package functions as described.
    - HerculesStudio requires hercules >= 3.06-4 which is not available yet
    - I decreased the dependency to 3.06-3 and installed the package available in bodhi
    - I wasn't able to get hercules run in HerculesStudio. It terminates with 
      "unable to open DLL dyngui: file not found"

[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
    - no scriptlets needed

[.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
    - no subpackages

Comment 6 Dan Horák 2009-09-16 12:04:49 UTC
(In reply to comment #5)
> The build requires hercules >= 3.06-4 which is not available yet. Are you
> planning to create another hercules release? 

The N-V-R above is valid only for Rawhide, it will be (and needs to be) updated for F-11, F-10 and EL-5.
 
> I wasn't able to run hercules-3.0.6-3 in HerculesStudio (see below) but maybe I
> simply missed a configuration setting, as I'm not familiar with hercules and
> its configuration. :) It works on the command-line though.

You must open (or create) a config file (eg. Fedora/s390x from http://alt.fedoraproject.org/pub/alt/spins/S390/) and then use Command/Power on from menu. It will show the devices on left and console output in the main window.

Comment 7 Martin Gieseking 2009-09-16 13:59:23 UTC
(In reply to comment #6)
> You must open (or create) a config file (eg. Fedora/s390x from
> http://alt.fedoraproject.org/pub/alt/spins/S390/) and then use Command/Power on
> from menu. 

Yes, I tried that but got the following error messages in the text area:
  HHCHD007E unable to open DLL dyngui: file not found
  HHCIN008S DYNGUI.DLL load failed; Hercules terminated.

It's strange that hercules tries to load a dll while its expected to use dyngui.so from /usr/lib/hercules. I also get this error when calling hercules manually by
$ hercules -d -f /tmp/hercules.cnf EXTERNALGUI

Anyway, this seems to be a problem with the hercules package I used (hercules-3.06-3.fc11.i586 from updates-testing). The hercstudio package is set up properly so that we can finish the review here.

------------------------
The package is APPROVED.
------------------------

Comment 8 Dan Horák 2009-09-16 14:06:43 UTC
Maybe there are some hidden issues in Hercules directly, because the GUI available only on Windows until now.

Thanks for the review.

Comment 9 Dan Horák 2009-09-16 17:06:08 UTC
New Package CVS Request
=======================
Package Name: hercstudio
Short Description: GUI for Hercules
Owners: sharkcz
Branches: F-10 F-11 EL-5

Comment 10 Jason Tibbitts 2009-09-16 21:47:39 UTC
CVS done.

Comment 11 Dan Horák 2009-09-17 12:31:57 UTC
Imported and built.


Note You need to log in before you can comment on or make changes to this bug.