Spec URL: http://simo.fedorapeople.org/libtevent/libtevent.spec SRPM URL: http://simo.fedorapeople.org/libtevent/libtevent-0.9.8-0.fc11.src.rpm Description: Tevent is an event system based on the talloc memory management library. It is the core event system used in Samba. Tevent has support for many event types, including timers, signals, and the classic file descriptor events. Tevent also provide helpers to deal with asynchronous code providing the tevent_req (Tevent Request) functions.
libtevent is actually already available (with an older version) in Fedora as it is built out of the samba4 package. Plan is to stop building it as part of that package and make this new independent libtevent package instead. Prompted by upstream finally releasing a libtevent tarball.
Hi, here's some issues that I've found: Package builds successfully in mock. Release starts from 0, should be 1. The summary really doesn't say much. Maybe something along the lines of "Event system based on libtalloc"? Maybe you can copy&paste the description from tevent home page. Copy & paste errors: Summary: Developer tools for the Talloc library A library that implements a hierarchical allocator with destructors. Header files needed to develop programs that link against the Talloc library. Please use %post and %postun with the -p switch as recommended in https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries Please don't pass --prefix=%{_usr} to %configure, it is not necessary (see the output of rpm --eval %configure) Unneeded dependencies: libxslt, docbook-style-xsl It seems that the autoconf dependency and running ./autogen.sh is unnecessary, the package seems to build OK without them. Outstanding issues from the review guidelines: MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. rpmlint output: libtevent.x86_64: W: shared-lib-calls-exit /usr/lib64/libtevent.so.0.9.8 exit.5 libtevent.x86_64: W: no-documentation libtevent.x86_64: W: one-line-command-in-%post /sbin/ldconfig libtevent.x86_64: W: one-line-command-in-%postun /sbin/ldconfig 4 packages and 0 specfiles checked; 0 errors, 5 warnings. I couldn't find any documentation myself, so the no-documentation warning is understandable. I already talked about the %post{,un} scriplets.
Ok uploaded new srpm and spec file in the same place. I think I have addressed all issues, and I am going to notify upstream about license files.
Sorry, I just noticed one little bit: rm -f $RPM_BUILD_ROOT%{_libdir}/libtevent.a I think it would be better to not use -f here. This however is not a blocker, so just use your own judgement. All the blockers were addressed, this package is APPROVED.
New Package CVS Request ======================= Package Name: libtevent Short Description: Tevent is an event system based on the talloc memory management library. Owners: simo Branches: F-11 InitialCC: gd
CVS Done
Ping?
Package Change Request ====================== Package Name: libtdb New Branches: EL-5 Owners: sgallagh This is being branched in preparation for building the SSSD in EPEL. (libtevent is a dependency) I have simo's permission to become the EPEL maintainer for this package.
CVS done.
Oops, well, cvs done for libtdb. Did you want libevent instead?
I wanted both. That was a copy-paste error. (I submitted the request for libtdb first)
CVS done on libtevent as well.