Bug 522355 - Review Request: lohit-sindhi-fonts - Open Type Font for Sindhi Language
Summary: Review Request: lohit-sindhi-fonts - Open Type Font for Sindhi Language
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-09-10 06:43 UTC by Pravin Satpute
Modified: 2009-09-11 11:57 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-11 11:57:51 UTC
panemade: fedora-review+
petersen: fedora-cvs+


Attachments (Terms of Use)

Description Pravin Satpute 2009-09-10 06:43:01 UTC
SPEC URL : http://pravins.fedorapeople.org/SPECS/lohit-sindhi-fonts.spec

SRPM URL :
http://pravins.fedorapeople.org/SRPMS/lohit-sindhi-fonts-2.4.3-1.fc11.src.rpm

This package contains open type fonts for sindhi language, Devanagari script.

Please note that this were part of lohit-fonts package previously, now lohit
upstream releasing it as a separate tarball.

Comment 1 Parag AN(पराग) 2009-09-10 13:44:49 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1667836
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
36dcebfdd98debb6f4124826b23e75c7f80cc3b4  lohit-sindhi-2.4.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ fonts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

APPROVED.

Comment 2 Jens Petersen 2009-09-11 08:59:07 UTC
cvs admin done with:

Package Name: lohit-sindhi-fonts
Short Description: Free Sindhi Open Type Font
Owners: pravins
Branches: devel
InitialCC: fonts-sig i18n-team

Comment 3 Pravin Satpute 2009-09-11 11:36:59 UTC
completed build
Thanks Parag and Jens


Note You need to log in before you can comment on or make changes to this bug.