Created attachment 360527 [details]
suggested changes to build with the split nss

These are possible changes to build against the nss after the split into nss, nss-softokn, and nss-util. I may have made more changes that are absolutely required

The problem is that nssutil3.so library is now provided by the nss-util
package, other libraries are now provided by nss-softokn.

Executing nss-softokn-config --libs freebl softokn shows
-Wl,/usr/lib -L/usr/lib -lfreebl3 -lnssdbm3 -lnsoftokn3
and executing nsss-util-config --libs nssutil shows
-Wl, -L -lnssutil3

For Fedora 12 we are splitting two new packages, nss-softoken and nss-util, see
https://fedoraproject.org/wiki/Features/SplitSoftoknFromNSS

The attachment suggest changes that could be made to xulrunner expanding
BuildRequires to include nss-softokn and nss-util. Based on these cahnges I
tried a scratch build
http://koji.fedoraproject.org/koji/taskinfo?taskID=1668326

It failed but I suspect for reasons other than the nss split.

Related, why are we using nss-config and not pkg-config?

Comment on attachment 360527 [details]
suggested changes to build with the split nss

>Index: xulrunner-mozconfig

>+ac_add_options --with-system-nss-util
>+ac_add_options --with-system-nss-softokn

I looked in mozilla/configure.in and I do not see these options there.  While the softokn and util libs/headers may be present on the build system, xulrunner/firefox do not know how to use them.

(In reply to comment #2)
> The problem is that nssutil3.so library is now provided by the nss-util
> package, other libraries are now provided by nss-softokn.
> 
> Executing nss-softokn-config --libs freebl softokn shows
> -Wl,/usr/lib -L/usr/lib -lfreebl3 -lnssdbm3 -lnsoftokn3

This '-Wl,/usr/lib' is also wrong. Gcc handle it as a -l/usr/lib and reports that /usr/lib is a directory and not a file (dynamic linked library). On the other hand this '-Wl,-rpath-link,/usr/lib' is ok.

The use of -rpath-link is flagged as an error by rplint and after asking around I removed it. I could (1) restore it (in nss, nss-softojkn, and nss-util) and make an official build or (2) I could restore it locally on my system, make scratch builds for the xulrunner build to try. 

Jan, could you build xulrunner against my scratch builds for now until we work out the changes on my side and your side that are actually needed?

Elio, to sum up the situation:

  BEFORE: rpmlint complained, but things could build against nss
  AFTER:  rpmlint is happy, but things cannot build against nss because of
          invalid link lines provided by nss-config

The current situation is a bad tradeoff, especially because it is preventing security updates from being built.  There is no reason why fixing a linting issue should be cause for leaving packages in a broken state.

I think the best thing to do is to revert the rpath change for now, and then we can figure out what else needs to be done.

I agree, I am going to revert some of my changes. Xulrunners' build system shouldn't have to change because of of split and other cleaning up. I'll restore the -rpath-link and until I find out how to use some form chaining information with pkgconfig I'm restoring nssutil to the list for nss. Give me at least a couple of hours as I plan to do a chained build.

Did the chain build and after the dist-12 repo was rebuilt I launched an xulrunner scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=1669735
which should be finished by the time you read this.

Thanks, it looks like it built successfully: http://koji.fedoraproject.org/koji/buildinfo?buildID=131150

this is fixed now, yes?

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

(In reply to comment #11) Yes, it is fixed.

let's close, then.

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers