Bug 522657 - Review Request: kmymoney2-aqbanking - Online banking plugin for KMyMoney
Summary: Review Request: kmymoney2-aqbanking - Online banking plugin for KMyMoney
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chitlesh GOORAH
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-09-11 00:04 UTC by Rex Dieter
Modified: 2009-10-21 00:49 UTC (History)
2 users (show)

Fixed In Version: 1.0.2-1.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-10-21 00:49:57 UTC
Type: ---
Embargoed:
chitlesh: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Rex Dieter 2009-09-11 00:13:33 UTC
rpmlint *.rpm x86_64/*.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1669487

Comment 2 Chitlesh GOORAH 2009-09-24 18:10:40 UTC
License should be GPLv2.

- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matches the base package %{name}
- MUST: The package meets the Packaging Guidelines.
- MUST: The package is licensed (GPLv2) with an open-source compatible license
and meet other legal requirements as defined in the legal section of Packaging
Guidelines.
- MUST: The License field in the package spec file matches the actual license.
- MUST: the source package includes the text of the license(s) in its own file,
then that file, containing the text of the license(s) for the package is
included in %doc.
- MUST: the package does not contain any duplicate files in the %files
- MUST: the package owns all directories that it creates.
- MUST: The spec file must be written in American English.
- MUST: The spec file for the package is be legible. 
- MUST: The sources used to build the package must matches the upstream source,
as provided in the spec URL.
- MUST: The package successfully compiles and builds into binary rpms on at
least i586.
- MUST: All build dependencies is listed in BuildRequires.
- MUST: The spec file handles locales properly.: No locales in this package
- MUST: the package is not designed to be relocatable
- MUST: Permissions on files are set properly.
- MUST: The package has a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
- MUST: The package consistently uses macros, as described in the macros
section of Packaging Guidelines.
- MUST: The package contains code, or permissible content. This is described in
detail in the code vs. content section of Packaging Guidelines.
- MUST: There are no Large documentation files
- MUST: %doc does not affect the runtime of the application. To summarize: If
it is in %doc, the program must run properly if it is not present.
- MUST: The package does not contain library files with a suffix 
? MUST: Package does contain any .la libtool archives (however needed to function)
- MUST: Package does not own files or directories already owned by other
packages. 

SHOULD Items:

 - SHOULD: The source package doesn't include license text(s) as COPYING
 - SHOULD: mock builds successfully in i586.
 - SHOULD: The reviewer tested that the package functions as described. A
package should not segfault instead of running, for example.
 - SHOULD:  Those scriptlets used are sane. 
 - SHOULD: No subpackages present.

Approved

Please fix the license before committing.

Comment 3 Rex Dieter 2009-09-24 18:20:23 UTC
I'll clarify with upstream, but for what it's worth, source files all either contain variants of:

 *   This program is free software; you can redistribute it and/or modify  *
 *   it under the terms of the GNU General Public License as published by  *
 *   the Free Software Foundation; either version 2 of the License, or     *
 *   (at your option) any later version.   

or

 ***************************************************************************
 *          Please see toplevel file COPYING for license details           *
 ***************************************************************************/

The latter being a cop-out really.  :)

Comment 4 Rex Dieter 2009-09-24 18:23:23 UTC
New Package CVS Request
=======================
Package Name: kmymoney2-aqbanking
Short Description: Online banking plugin for KMyMoney
Owners: rdieter
Branches: F-10 F-11 EL-5
InitialCC:

Comment 5 Chitlesh GOORAH 2009-09-24 18:39:29 UTC
(In reply to comment #3)
> The latter being a cop-out really.  :)  

It's ok for me :)

Comment 6 Kevin Fenzi 2009-09-25 16:13:30 UTC
cvs done.

Comment 7 Fedora Update System 2009-09-30 17:29:49 UTC
kmymoney2-1.0.1-1.fc11,kmymoney2-aqbanking-1.0-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/kmymoney2-1.0.1-1.fc11,kmymoney2-aqbanking-1.0-2.fc11

Comment 8 Fedora Update System 2009-10-03 19:09:28 UTC
kmymoney2-1.0.1-1.fc11, kmymoney2-aqbanking-1.0-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update kmymoney2 kmymoney2-aqbanking'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10215

Comment 9 Fedora Update System 2009-10-09 03:35:16 UTC
kmymoney2-1.0.2-1.fc11, kmymoney2-aqbanking-1.0-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update kmymoney2 kmymoney2-aqbanking'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10215

Comment 10 Fedora Update System 2009-10-21 00:49:52 UTC
kmymoney2-1.0.2-1.fc11, kmymoney2-aqbanking-1.0-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.