Bug 522726 - Review Request: maven-plugin-build-helper - Build Helper Maven Plugin
Summary: Review Request: maven-plugin-build-helper - Build Helper Maven Plugin
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Andrew Overholt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-09-11 08:14 UTC by Alexander Kurtakov
Modified: 2009-09-13 16:13 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-13 16:13:53 UTC
overholt: fedora-review+
tibbs: fedora-cvs+


Attachments (Terms of Use)

Description Alexander Kurtakov 2009-09-11 08:14:18 UTC
Spec URL: http://akurtakov.fedorapeople.org/maven-plugin-build-helper.spec
SRPM URL: http://akurtakov.fedorapeople.org/maven-plugin-build-helper-1.4-1.fc11.src.rpm
Description: This plugin contains various small independent goals to assist with
Maven build lifecycle.

Comment 1 Andrew Overholt 2009-09-11 15:19:18 UTC
X one file is under ASL 2.0 (everything else is MIT) so please update License to reflect
X please use your full name and email address in %changelog :)
X please add Requires(post) and postun on jpackage-utils

- source matches upstream
- macros good
- builds fine
- versioning good
- %files fine
- rpmlint fine:

$ rpmlint /home/overholt/rpmbuild/SRPMS/maven-plugin-build-helper-1.4-1.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-build-helper-1.4-1.fc11.noarch.rpm
maven-plugin-build-helper.noarch: W: no-documentation
maven-plugin-build-helper.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-plugin-build-helper
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-build-helper-javadoc-1.4-1.fc11.noarch.rpm
-standard-dir-perm /usr/share/javadoc/maven-plugin-build-helper-1.4/org 0775
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 2 Alexander Kurtakov 2009-09-11 15:38:11 UTC
(In reply to comment #1)
> X one file is under ASL 2.0 (everything else is MIT) so please update License
> to reflect
Fixed.
> X please use your full name and email address in %changelog :)
Fixed :)
> X please add Requires(post) and postun on jpackage-utils
Fixed.
> 
> - source matches upstream
> - macros good
> - builds fine
> - versioning good
> - %files fine
> - rpmlint fine:
> 
> $ rpmlint
> /home/overholt/rpmbuild/SRPMS/maven-plugin-build-helper-1.4-1.fc11.src.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> $ rpmlint
> /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-build-helper-1.4-1.fc11.noarch.rpm
> maven-plugin-build-helper.noarch: W: no-documentation
> maven-plugin-build-helper.noarch: W: non-conffile-in-etc
> /etc/maven/fragments/maven-plugin-build-helper
> 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> $ rpmlint
> /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-build-helper-javadoc-1.4-1.fc11.noarch.rpm
> -standard-dir-perm /usr/share/javadoc/maven-plugin-build-helper-1.4/org 0775
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.  

New sources:
Spec URL: http://akurtakov.fedorapeople.org/maven-plugin-build-helper.spec
SRPM URL:
http://akurtakov.fedorapeople.org/maven-plugin-build-helper-1.4-1.fc11.src.rpm

Comment 3 Andrew Overholt 2009-09-11 15:53:46 UTC
Thanks, approved.

Comment 4 Alexander Kurtakov 2009-09-11 15:57:56 UTC
New Package CVS Request
=======================
Package Name: maven-plugin-build-helper
Short Description: Build Helper Maven Plugin
Owners: akurtakov
Branches: 
InitialCC:

Comment 5 Jason Tibbitts 2009-09-11 20:17:39 UTC
CVS done.

Comment 6 Alexander Kurtakov 2009-09-13 16:13:53 UTC
Build in rawhide.


Note You need to log in before you can comment on or make changes to this bug.