Bug 522727 - Review Request: maven-plugin-exec - Exec Maven Plugin
Summary: Review Request: maven-plugin-exec - Exec Maven Plugin
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Andrew Overholt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-09-11 08:16 UTC by Alexander Kurtakov
Modified: 2009-09-13 16:13 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-13 16:13:12 UTC
overholt: fedora-review+
tibbs: fedora-cvs+


Attachments (Terms of Use)

Description Alexander Kurtakov 2009-09-11 08:16:13 UTC
Spec URL: http://akurtakov.fedorapeople.org/maven-plugin-exec.spec
SRPM URL: http://akurtakov.fedorapeople.org/maven-plugin-exec-1.1-1.fc11.src.rpm
Description: A plugin to allow execution of system and Java programs

Comment 1 Andrew Overholt 2009-09-11 14:41:46 UTC
X let's put a version requirement on maven2-common-poms
? should we add versions to other BRs/Rs?
X need changelog entries
X need %post/%postun requires on jpackage-utils
X LICENSE.txt and all other licensing text conflicts; remove LICENSE.txt and report upstream?

- %files good
- sources match upstream
- naming good
- macros fine
- sources match
- builds fine
- rpmlint will be fine once changelog entries added:

$ rpmlint /home/overholt/rpmbuild/SRPMS/maven-plugin-exec-1.1-1.fc11.src.rpm 
maven-plugin-exec.src: E: no-changelogname-tag

$ rpmlint /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-exec-1.1-1.fc11.noarch.rpm
maven-plugin-exec.noarch: E: no-changelogname-tag
maven-plugin-exec.noarch: W: no-documentation
maven-plugin-exec.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-plugin-exec

$ rpmlint /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-exec-javadoc-1.1-1.fc11.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 2 Alexander Kurtakov 2009-09-11 15:33:47 UTC
(In reply to comment #1)
> X let's put a version requirement on maven2-common-poms
Fixed.
> ? should we add versions to other BRs/Rs?
No, it builds fine in koji.
> X need changelog entries
Fixed.
> X need %post/%postun requires on jpackage-utils
Fixed.
> X LICENSE.txt and all other licensing text conflicts; remove LICENSE.txt and
> report upstream?
> 
> - %files good
> - sources match upstream
> - naming good
> - macros fine
> - sources match
> - builds fine
> - rpmlint will be fine once changelog entries added:
> 
> $ rpmlint /home/overholt/rpmbuild/SRPMS/maven-plugin-exec-1.1-1.fc11.src.rpm 
> maven-plugin-exec.src: E: no-changelogname-tag
> 
> $ rpmlint
> /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-exec-1.1-1.fc11.noarch.rpm
> maven-plugin-exec.noarch: E: no-changelogname-tag
> maven-plugin-exec.noarch: W: no-documentation
> maven-plugin-exec.noarch: W: non-conffile-in-etc
> /etc/maven/fragments/maven-plugin-exec
> 
> $ rpmlint
> /home/overholt/rpmbuild/RPMS/noarch/maven-plugin-exec-javadoc-1.1-1.fc11.noarch.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.  

New sources:
Spec URL: http://akurtakov.fedorapeople.org/maven-plugin-exec.spec
SRPM URL:
http://akurtakov.fedorapeople.org/maven-plugin-exec-1.1-1.fc11.src.rpm

Comment 3 Andrew Overholt 2009-09-11 15:53:35 UTC
Approved.

Comment 4 Alexander Kurtakov 2009-09-11 15:56:40 UTC
New Package CVS Request
=======================
Package Name: maven-plugin-exec
Short Description: Exec Maven Plugin
Owners: akurtakov
Branches: 
InitialCC:

Comment 5 Jason Tibbitts 2009-09-11 20:18:17 UTC
CVS done.

Comment 6 Alexander Kurtakov 2009-09-13 16:13:12 UTC
Build in rawhide.


Note You need to log in before you can comment on or make changes to this bug.