Description of problem: The nslcd initscript doesn't implement mandatory option force-reload. See https://fedoraproject.org/wiki/FCNewInit/Initscripts. Version-Release number of selected component (if applicable): nss-ldapd-0.6.11-1.fc12 How reproducible: always Steps to Reproduce: 1. service nslcd force-reload Actual results: Option not implmented Expected results: Option implemented according to https://fedoraproject.org/wiki/FCNewInit/Initscripts
Not sure why this is assigned to me.
The page that you cite: https://fedoraproject.org/wiki/FCNewInit/Initscripts is not part of the Fedora packaging guidelines, and in fact has a small handful of inconsistencies with them. It appears to be part of this project: https://fedoraproject.org/wiki/FCNewInit which in turn refers to this release feature: https://fedoraproject.org/wiki/Releases/FeatureNewInit As you'll see if you look at that feature page, the feature was obsoleted over a year ago by a decision to move towards upstart instead of carrying out the changes on the FCNewInit pages. Fedora's guidelines on init scripts can be found here: http://fedoraproject.org/wiki/Packaging:SysVInitScript (There's even a comment to this effect early in the tracker bug that you've marked this one as blocking.) The Fedora guidelines don't require strict LSB compliance, though there are many similarities. The specific item you raise (the missing force-reload action) is indeed a problem according to the Fedora init script guidelines. A careful reading of them actually shows that the nss-ldapd init script has a more sizable list of issues where it violates the guidelines. I'll be creating an attachment to address all of these momentarily.
Created attachment 361224 [details] Patch to improve nslcd.init and scriptlet compliance with packaging guidelines o Make the spec file use the %{_initddir} macro instead of the deprecated %{_initrddir} macro o Only infer that the nslcd service should be enabled if USELDAP=yes on the first package installation; do not alter runlevel settings that the user has selected when upgrading or reinstalling o Fix spacing inconsistency in chkconfig '# description:' entry o Remove LSB '# Default-Stop:' entry; it is only supposed to be present if there is a '# Default-Start:' entry o Correct LSB '# Description:' entry; it is required to be identical to the chkconfig '# description:' entry o Use the preferred /etc/rc.d/init.d directory instead of /etc/init.d o Make the 'start' action do nothing if nslcd is already running; previously we would start a second daemon o Make the 'stop' action do nothing if nslcd is already shut down o Implement the required 'try-restart' action as a synonym of 'condrestart' o Make the 'reload' action return 3 to indicate that it is unimplemented o Implement the required 'force-reload' action as a synonym of 'restart' o Update usage line to include the new actions
Mitch, that looks great to me. Adding a -p to the status function call to catch dead-but-pid-file-exists errors and committing to CVS.
when will the new build be ready for testing?
(In reply to comment #5) > when will the new build be ready for testing? I was half-expecting other packages to trigger a rebuild soon enough, but I've just kicked one off anyway. It should make the next compose, so... tomorrow?
VERIFIED as fixed in nss-ldapd-0.6.11-2.fc12.i686.
This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle. Changing version to '12'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping
The VERIFIED, FAILS_QA and RELEASE_PENDING bug states are not used by Fedora (they are used in the RHEL process). --- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers