Red Hat Bugzilla – Bug 523418
xmldesc with a typo makes libvirtd sefault
Last modified: 2010-03-30 04:09:57 EDT
Description of problem:
I've used createLinux with the following section in xmldesc
note that "def" instead of "dev". It's ok for libvirt not to like it, but it should not die.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
<type arch='i686' machine='pc'>hvm</type>
<input type='mouse' bus='ps2'/>
<graphics type='vnc' port='5910' autoport='no' listen='0'/>
error code returned
Fix is trivial, posted it upstream, I expect to have this fixed there
Not sure if it's worth a Z-Stream errata, but we should definitely fix this
for 5.5 at least,
wow, I'm so lucky to have stepped on the only place where virXMLPropString()'s return value was not tested.
Well fix is upstream now, I will try to push the fix on the RHEL-5 branch
but no hurry if we don't do a an errata for it.
Created attachment 370139 [details]
trivial backport to RHEL-5.4 of upstream patch
libvirt-0.6.3-22.el5 has been built in dist-5E-qu-candidate with
The bugs has been fixed in libvirt-0.6.3-28.el5
I tried the bug on libvirt-0.6.3-20.el5 using "virsh define segfault.xml" XMLdesc like above xml definition. Libvirt reports error:
error:Faied to define domain from segfault.xml
error:server closed connection
and at the same time, the libvirtd died.
the output of "service libvirtd status" is libvirtd dead but pid file exists
error: Failed to define domain from segfault.xml
error: internal error No <source> 'dev' attribute specified with <interface type='bridge'/>
the libvirt daemon is running.
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.