Spec URL: http://cwickert.fedorapeople.org/review/xfce4-xfswitch-plugin.spec SRPM URL: http://cwickert.fedorapeople.org/review/xfce4-xfswitch-plugin-0.0.1-1.fc12.src.rpm Description: Xfswitch-plugin is a user switching plugin for the Xfce4 Panel. It allows you to leave the current session opened and open a new session with another user. At the moment it relies on GDM, but other display managers will be supported in the future.
I'd be happy to review this. Look for a full review in a while...
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: cb204f4a507f462d019529af6f547731 xfswitch-plugin-0.0.1.tar.gz cb204f4a507f462d019529af6f547731 xfswitch-plugin-0.0.1.tar.gz.orig OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Rpmlint says: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. (ie, nothing) A simple package and everything looks good. This package is APPROVED.
Thanks, that was quick! New Package CVS Request ======================= Package Name: xfce4-xfswitch-plugin Short Description: User switching plugin for the Xfce4 Panel Owners: cwickert Branches: F-10 F-11 InitialCC:
cvs done.
xfce4-xfswitch-plugin-0.0.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/xfce4-xfswitch-plugin-0.0.1-1.fc11
xfce4-xfswitch-plugin-0.0.1-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/xfce4-xfswitch-plugin-0.0.1-1.fc10
This is imported and built. Closing now. :)
xfce4-xfswitch-plugin-0.0.1-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
xfce4-xfswitch-plugin-0.0.1-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: xfce4-xfswitch-plugin New Branches: epel7 Owners: cwickert InitialCC: nonamedotc
Git done (by process-git-requests).