According to https://fedoraproject.org/wiki/FCNewInit/Initscripts dumpconf init script have some LSB-compilant problems: 1. LSB Header 2. insufficient rights, there should be return code 4 # su testuserqa -c "service netconsole restart"; echo $? now: 0 expected: 4 3. /var/lock/subsys/netconsole should be created when service starts and if netconsole is dead and /var/lock/subsys/netconsole lock file exists then status action should return code "2". 4. netconsole init script should also support "try-restart" and "force-reload" actions. The reason of filling it is "InitScripts LSB compliance project"
(In reply to comment #0) > According to https://fedoraproject.org/wiki/FCNewInit/Initscripts dumpconf init > script have some LSB-compilant problems: Not a vaild guideline. I'll assume you mean the valid guideline page. > 1. LSB Header > > 2. insufficient rights, there should be return code 4 > # su testuserqa -c "service netconsole restart"; echo $? > now: 0 > expected: 4 modprobe does not distinguish error varieties. Return code set to '1', which is a valid error return. > 3. /var/lock/subsys/netconsole should be created when service starts and if > netconsole is dead and /var/lock/subsys/netconsole lock file exists then > status action should return code "2". There is not a daemon, this makes no sense whatsoever. > 4. netconsole init script should also support "try-restart" and > "force-reload" actions. try-restart is optional. force-reload added. http://git.fedorahosted.org/git/?p=initscripts.git;a=commitdiff;h=709ef82796b5340fd286f1416ee967ac8c1979f8
Bill, can you please also fix 5. nonexist action should have return code 3 and usage info: # service netconsole nonexist ; echo $? now: 3 expected: 2 Sorry for that.
How so? 2 is 'invalid or excess arguments'.
Yes, it a bit confused. It was a topic of discussion in QE. So it was decided to use code "2" instead of "3" (unimplemented feature)
Is there any commentary on the upstream LSB on this?
I was not able to find something about this. Here is a Fedora initscript template: https://fedoraproject.org/wiki/Packaging/SysVInitScript