Bug 524795 - libsigsegv allocates alternate stack on the main stack
Summary: libsigsegv allocates alternate stack on the main stack
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libsigsegv
Version: 11
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-09-22 08:37 UTC by Paolo Bonzini
Modified: 2013-01-10 05:29 UTC (History)
3 users (show)

Fixed In Version: 2.6-6.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-11-11 15:00:09 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Paolo Bonzini 2009-09-22 08:37:37 UTC
As seen on http://savannah.gnu.org/bugs/?27475 libsigsegv's behavior broke with the latest F11 GCC update.

The upstream fixes are 54b612e and 4f14ef8 in git://git.sv.gnu.org/libsigsegv.git and they should be cherry-picked into the F11 and rawhide packages.

Comment 1 Rex Dieter 2009-09-22 18:01:37 UTC
funky, I'll take a look.

Comment 2 Rex Dieter 2009-09-22 18:07:33 UTC
Paolo, thanks by the way for all the help here, would you be interested in helping maintain this package (ie, give you commit access to fix items)?

Comment 3 Rex Dieter 2009-09-22 18:57:35 UTC
Woo, good news bad news.

Here's a scratch build with adjusted patches:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1698646

Good news, build on x86_64 works

Bad news, ppc64 fails now, 'make check' failures:

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.zj7Ujq
+ umask 022
+ cd /builddir/build/BUILD
+ cd libsigsegv-2.6
+ unset DISPLAY
+ make check
Making check in src
make[1]: Entering directory `/builddir/build/BUILD/libsigsegv-2.6/src'
make[1]: Nothing to be done for `check'.
make[1]: Leaving directory `/builddir/build/BUILD/libsigsegv-2.6/src'
Making check in tests
make[1]: Entering directory `/builddir/build/BUILD/libsigsegv-2.6/tests'
make  check-TESTS
make[2]: Entering directory `/builddir/build/BUILD/libsigsegv-2.6/tests'
Test passed.
PASS: sigsegv1
Test passed.
PASS: sigsegv2
Doing SIGSEGV pass 1.
Stack overflow 1 caught.
Doing SIGSEGV pass 2.
Stack overflow 2 caught.
Test passed.
PASS: sigsegv3
/bin/sh: line 5: 12410 Segmentation fault      ${dir}$tst
FAIL: stackoverflow1
/bin/sh: line 5: 12434 Segmentation fault      ${dir}$tst
FAIL: stackoverflow2
===================
2 of 5 tests failed
===================



Gonna (re)try the build, to make sure it's reproducible and not just gremlins.

Comment 4 Rex Dieter 2009-09-22 19:02:13 UTC
Meh, looks reproducible,
http://koji.fedoraproject.org/koji/taskinfo?taskID=1699058

Comment 5 Rex Dieter 2009-09-22 19:08:38 UTC
OK, looks like currently(1) there's nothing on ppc64 using libsigsegv, so we
could (at least temporarily) get away with an
ExcludeArch: ppc64


(1) except for bug #511443 where gawk wants to start using (system) libsigsegv
too

Comment 6 Rex Dieter 2009-09-22 19:26:15 UTC
Noticed one thing, but the .m4 modifications (from libsigsegv-2.6 anyway) use
char mystack[2 * SIGSTKSZ];

whereas the tests (still) use:
char mystack[SIGSTKSZ];

is that kosher/intentional?

Comment 7 Rex Dieter 2009-09-22 19:28:13 UTC
interesting, adjusting the patch so the tests use
char mystack[2 * SIGSTKSZ];
too, makes the ppc64 test segfaults go away.

Comment 8 Jesse Keating 2009-10-21 22:32:29 UTC
What's the status here?  We're running out of time, is this something we'd slip the release for?

Comment 9 Rex Dieter 2009-10-21 23:14:43 UTC
Should be resolved as of

%changelog
* Tue Sep 22 2009 Rex Dieter <rdieter> - 2.6-6
- respin mystack patch

* Tue Sep 22 2009 Rex Dieter <rdieter> - 2.6-5
- libsigsegv allocates alternate stack on the main stack (#524796)

I guess I meant to issue on F-11 update, and seem to have put it off, will take care of that asap


Paolo, any feedback on comment #7 ?

Comment 10 Fedora Update System 2009-10-22 01:13:42 UTC
libsigsegv-2.6-6.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/libsigsegv-2.6-6.fc11

Comment 11 Paolo Bonzini 2009-10-22 06:42:19 UTC
> interesting, adjusting the patch so the tests use
> char mystack[2 * SIGSTKSZ];
> too, makes the ppc64 test segfaults go away.  

I would have to debug it, but I see no reason not to do that and remove the exclusion.

Comment 12 Fedora Update System 2009-10-27 06:43:33 UTC
libsigsegv-2.6-6.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update libsigsegv'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10762

Comment 13 Adam Williamson 2009-10-30 18:47:54 UTC
no reason for this to block either of the two bugs it was blocking any more, they're both fixed.

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 14 Fedora Update System 2009-11-11 15:00:04 UTC
libsigsegv-2.6-6.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.