Hide Forgot
Spec URL: http://thomasj.fedorapeople.org/reviews/qtcurve-gtk2.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/qtcurve-gtk2-0.68.1-1.fc10.src.rpm Description: QtCurve is a desktop theme for the GTK+ and Qt widget toolkits, allowing users to achieve a uniform look between three widget toolkits.: [thomas@tusdell SPECS]$ rpmlint qtcurve-gtk2.spec ../SRPMS/qtcurve-gtk2-0.68.1-1.fc10.src.rpm ../RPMS/x86_64/qtcurve-gtk2-0.68.1-1.fc10.x86_64.rpm ../RPMS/x86_64/qtcurve-gtk2-debuginfo-0.68.1-1.fc10.x86_64.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings. http://koji.fedoraproject.org/koji/taskinfo?taskID=1714499
A few comments: 1. can drop extranenous BuildRequires: qt-devel 2. drop Requires: qtcurve-kde4... (agreed on irc) 3. description: allowing users to achieve a uniform look between three widget toolkits. "three"? maybe meant to say "these" here. ? 4. %post/%postun scriplets not needed 5. %files , instead use: %{_libdir}/gtk-2.0/*/engines/libqtcurve.so %{_datadir}/themes/QtCurve/ no need for _kde4 macros here, and to own QtCurve/ dir
(In reply to comment #1) > A few comments: > > 1. can drop extranenous > BuildRequires: qt-devel Done > 2. drop > Requires: qtcurve-kde4... > (agreed on irc) Done > 3. description: > allowing users to achieve a uniform look between three widget toolkits. > "three"? maybe meant to say "these" here. ? Yeah, my bad. There are three if one includes -kde3 i guess (description taken from upstream). Since i'm not building it AND it sounds even better, i changed to "these". > 4. %post/%postun scriplets not needed Done. > 5. %files , instead use: > %{_libdir}/gtk-2.0/*/engines/libqtcurve.so > %{_datadir}/themes/QtCurve/ > > no need for _kde4 macros here, and to own QtCurve/ dir Done [thomas@tusdell ~]$ rpmlint rpmbuild/SPECS/qtcurve-gtk2.spec rpmbuild/SRPMS/qtcurve-gtk2-0.69.0-1.fc10.src.rpm rpmbuild/RPMS/x86_64/qtcurve-gtk2-*69* 3 packages and 1 specfiles checked; 0 errors, 0 warnings. http://koji.fedoraproject.org/koji/taskinfo?taskID=1743212 Spec URL: http://thomasj.fedorapeople.org/reviews/qtcurve-gtk2.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/qtcurve-gtk2-0.69.0-1.fc10.src.rpm -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
OK, the rest looks simple and squeaky clean to me. (we can work together on 1 or 2 other cosmetic things that aren't review blockers). Been using it over the past day or so, and it works well. APPROVED.
New Package CVS Request ======================= Package Name: qtcurve-gtk2 Short Description: This is a set of widget styles for Gtk2 based apps Owners: thomasj Branches: F-10 F-11 F-12 InitialCC: -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
cvs done.
Thanks guys for the review and cvs/pkgdb work. It's built. I close it now. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers