Bug 526236 - Product disallownew should be converted to isactive in all 3.4 code
Summary: Product disallownew should be converted to isactive in all 3.4 code
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Bugzilla
Classification: Community
Component: Database
Version: 3.4
Hardware: All
OS: All
medium
medium vote
Target Milestone: ---
Assignee: PnT DevOps Devs
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: RHBZ34UpgradeTracker
TreeView+ depends on / blocked
 
Reported: 2009-09-29 12:22 UTC by Noura El hawary
Modified: 2013-06-24 02:04 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-29 21:37:13 UTC


Attachments (Terms of Use)

Description Noura El hawary 2009-09-29 12:22:28 UTC
Upstream has converted product field disallownew to isactive in their 3.5 bugzilla release as shown in this bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=493090

this has been merged partially into our branches/upstream3.4 code we need to do full conversion , disallownew still exist in the following places:

[root@localhost upstream-3.4]# grep -rl disallownew .
./redhat/jira-export-import.pl
./editproducts.cgi
./extensions/compat_xmlrpc/code/webservice.pl
./Bugzilla/Install/DB.pm
./Bugzilla/DB/Schema/Mysql.pm

Noura

Comment 1 David Lawrence 2009-09-29 21:37:13 UTC
Interesting story about this one. Actually in upstream 3.4 they are still using products.disallownew and products.isactive is used in their post-3.4 development tree (trunk). So I must have botched up the merge at some point and accidently pulled in this change to our 3.4 internal tree. So my vote is that we just go ahead with switching to products.isactive and then when we rebase later to 3.6, the change will already be implemented.

I have committed the fixes to SVN and closing this. We will create new bugs if we find any functionality issues with product.isactive use.

Dave


Note You need to log in before you can comment on or make changes to this bug.