Bug 526769 - libvirt logrotate settings should roll over weekly instead of daily
Summary: libvirt logrotate settings should roll over weekly instead of daily
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libvirt
Version: rawhide
Hardware: All
OS: Linux
high
medium
Target Milestone: ---
Assignee: Mark McLoughlin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F12VirtTarget
TreeView+ depends on / blocked
 
Reported: 2009-10-01 17:46 UTC by Cole Robinson
Modified: 2009-10-06 15:23 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-10-06 15:23:27 UTC
Type: ---


Attachments (Terms of Use)

Description Cole Robinson 2009-10-01 17:46:42 UTC
Since we no longer log qemu monitor output to the /var/log/libvirt/qemu logfile, there isn't much chance of these log files becoming huge in short periods of time. Using aggressive logrotate settings then provides little benefit at the cost of debug ability (for example, bug 524508c#12 ).

I think weekly, biweekly, or even monthly rotation should be enough, maybe removing compression altogether.

Comment 1 Daniel Veillard 2009-10-02 11:22:43 UTC
I would really keep compression in any case, as this leads to no loss of
informations.
Now how much information we keep by default is a trade-off, honestly
keeping them for a week should be sufficient to diagnose problem, but
I would be okay to switch that to weekly and rotate 4 to keep a month
worth of data instead of a week.

Daniel

Comment 2 Daniel Veillard 2009-10-02 11:25:54 UTC
this would also limit the number of entries in that directory, cut this
nearly by half for the same amount of VM, currently there is 8 files
per domain, usually of zero lenght if inactive, and we would lower this
to 5 files but bigger.

Daniel

Comment 3 Mark McLoughlin 2009-10-02 15:43:01 UTC
Yeah, this has been annoying me lately too

Let's switch to weekly

Comment 4 Daniel Veillard 2009-10-02 16:09:35 UTC
I posted the trivial patch upstream

Daniel

Comment 5 Daniel Veillard 2009-10-05 15:09:11 UTC
Okay fixed upstream, it will reach rawhide in a couple of weeks I think

Daniel

Comment 6 Mark McLoughlin 2009-10-05 15:21:18 UTC
We should pull this into F-12 before GA

Comment 7 Mark McLoughlin 2009-10-06 09:46:18 UTC
* Tue Oct  6 2009 Mark McLoughlin <markmc@redhat.com> - 0.7.1-9
- Change logrotate config to weekly (#526769)

Comment 8 Mark McLoughlin 2009-10-06 13:03:31 UTC
tag request : https://fedorahosted.org/rel-eng/ticket/2354

Comment 9 Mark McLoughlin 2009-10-06 15:23:27 UTC
tagged now


Note You need to log in before you can comment on or make changes to this bug.