Bug 526997 - Review Request: pdf2svg - Small tool to convert PDF files into SVG
Summary: Review Request: pdf2svg - Small tool to convert PDF files into SVG
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chitlesh GOORAH
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 526844
TreeView+ depends on / blocked
 
Reported: 2009-10-02 23:58 UTC by Ben Boeckel
Modified: 2009-10-14 01:48 UTC (History)
3 users (show)

Fixed In Version: 0.2.1-2.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-10-10 19:45:11 UTC
chitlesh: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Ben Boeckel 2009-10-02 23:58:52 UTC
Spec URL: http://benboeckel.net/packaging/pdf2svg/pdf2svg.spec
SRPM URL: http://benboeckel.net/packaging/pdf2svg/pdf2svg-0.2.1-1.fc11.src.rpm
Description:
A small tool to convert PDF files into SVG using poppler and cairo.

Comment 1 Martin Gieseking 2009-10-03 08:05:53 UTC
Just two quick comments:
- Requires: groff doesn't seem to be necessary
- drop INSTALL from %doc as it's not of much use in a binary package

Comment 2 Chitlesh GOORAH 2009-10-03 10:33:39 UTC
Ben, I'll do both reviews.

Do you mind reviewing this small package for me please ?
https://bugzilla.redhat.com/show_bug.cgi?id=505264

Comment 3 Chitlesh GOORAH 2009-10-04 12:10:53 UTC
Missing timestamps during make install :

make INSTALL="install -p" install DESTDIR=%{buildroot}

The package looks good. Update the spec file too in accordance to the comment #1. I'll finalize the package review.

Comment 5 Chitlesh GOORAH 2009-10-06 11:32:03 UTC
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matches the base package %{name}
- MUST: The package meets the Packaging Guidelines.
- MUST: The package is licensed (GPLv2+) with an open-source compatible license
and meet other legal requirements as defined in the legal section of Packaging
Guidelines.
- MUST: The License field in the package spec file matches the actual license.
- MUST: the source package includes the text of the license(s) in its own file,
then that file, containing the text of the license(s) for the package is
included in %doc.
- MUST: the package does not contain any duplicate files in the %files
- MUST: the package owns all directories that it creates.
- MUST: The spec file must be written in American English.
- MUST: The spec file for the package is be legible. 
- MUST: The sources used to build the package must matches the upstream source,
as provided in the spec URL.
- MUST: The package successfully compiles and builds into binary rpms on at
least i586.
- MUST: All build dependencies is listed in BuildRequires.
- MUST: The spec file handles locales properly.: No locales in this package
- MUST: the package is not designed to be relocatable
- MUST: Permissions on files are set properly.
- MUST: The package has a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
- MUST: The package consistently uses macros, as described in the macros
section of Packaging Guidelines.
- MUST: The package contains code, or permissible content. This is described in
detail in the code vs. content section of Packaging Guidelines.
- MUST: There are no Large documentation files
- MUST: %doc does not affect the runtime of the application. To summarize: If
it is in %doc, the program must run properly if it is not present.
- MUST: There are no Header files or static libraries 
- MUST: The package does not contain library files with a suffix 
- MUST: Package does NOT contain any .la libtool archives
- MUST: Package does not own files or directories already owned by other
packages. 

SHOULD Items:

 - SHOULD: The source package doesn't include license text(s) as COPYING
 - SHOULD: mock builds succcessfully in i586.
 - SHOULD: The reviewer tested that the package functions as described. A
package should not segfault instead of running, for example.
 - SHOULD:  Those scriptlets used are sane. 
 - SHOULD: No subpackages present.

Approved

Comment 6 Ben Boeckel 2009-10-06 15:44:51 UTC
New Package CVS Request
=======================
Package Name: pdf2svg
Short Description: Small tool to convert PDF files into SVG
Owners: mathstuf
Branches: F-10 F-11 F-12
InitialCC:

Comment 7 Kevin Fenzi 2009-10-06 17:27:11 UTC
cvs done.

Comment 8 Fedora Update System 2009-10-10 19:46:33 UTC
pdf2svg-0.2.1-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/pdf2svg-0.2.1-2.fc11

Comment 9 Fedora Update System 2009-10-10 19:46:37 UTC
pdf2svg-0.2.1-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/pdf2svg-0.2.1-2.fc12

Comment 10 Fedora Update System 2009-10-14 01:48:27 UTC
pdf2svg-0.2.1-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.