Bug 527259 - Broken --checkts behaviour
Summary: Broken --checkts behaviour
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: createrepo
Version: 11
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Luke Macken
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-05 15:48 UTC by Dmitry Butskoy
Modified: 2016-09-20 02:40 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-10-05 20:16:00 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
patch to fix the issue (1.11 KB, patch)
2009-10-05 15:48 UTC, Dmitry Butskoy
no flags Details | Diff

Description Dmitry Butskoy 2009-10-05 15:48:13 UTC
Created attachment 363703 [details]
patch to fix the issue

There is a '-C' or '--checkts' option for createrepo, to compare the ctime of the repodata/ and the most late ctime of rpms.

With version of 0.9.x it is not working (ie. false operations etc.)

There are two reasons for this issue:

1) already fixed in 0.9.8 -- createrepo must check the _data_ files in repodata/ dir, not the dir itself. Now, it check all the dirs, including repodata/ and a temporary .repodata/, and since the .repodata/ is "just created", it ctime is always newer than any rpm file...

2) Now createrepo (by a typo?) compares just _one of rpm files_, whereas shoud compare _all the rpm files_ against the metadata ctime.

Comment 1 seth vidal 2009-10-05 19:57:33 UTC
You seem to be combining two issues.

https://bugzilla.redhat.com/show_bug.cgi?id=512610

is the first one and it is fixed already.

The second issue does look like we're only ever looking at the first file in the rpm list. I'll take a look at that.

thanks

Comment 2 seth vidal 2009-10-05 20:16:00 UTC
applied the second part of your patch to createrepo.

Comment 3 Ville Skyttä 2009-11-24 20:57:56 UTC
Could we get a createrepo package update that contains this fix?

Comment 4 seth vidal 2009-11-24 21:03:50 UTC
oh y'all just want the world! :)

yah - I'll make a note.

Comment 5 seth vidal 2009-12-21 22:31:31 UTC
sorry this took so long - kept slipping off my todo list.

koji build is here: 

http://koji.fedoraproject.org/koji/taskinfo?taskID=1884661

please test it and let me know if it is all okay before I send it to bodhi.

thanks

Comment 6 Ville Skyttä 2009-12-22 06:34:49 UTC
Yep, that one appears to work for me on F-11.  I think the F-12+ versions need a similar fix as well, there doesn't seem to be a new build for them in koji yet.

Comment 7 Fedora Update System 2009-12-22 16:22:01 UTC
createrepo-0.9.7-8.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/createrepo-0.9.7-8.fc11

Comment 8 Fedora Update System 2009-12-22 16:22:10 UTC
createrepo-0.9.8-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/createrepo-0.9.8-3.fc12


Note You need to log in before you can comment on or make changes to this bug.