Bug 527496 - pci_dev->is_enabled is not set in RHEL5.4
Summary: pci_dev->is_enabled is not set in RHEL5.4
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.5
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Prarit Bhargava
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-06 16:11 UTC by Prarit Bhargava
Modified: 2010-03-30 07:38 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-30 07:38:56 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
RHEL5 fix for this issue (400 bytes, patch)
2009-10-06 16:11 UTC, Prarit Bhargava
no flags Details | Diff
RHEL5 fix for this issue (672 bytes, patch)
2009-10-06 16:16 UTC, Prarit Bhargava
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2010:0178 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.5 kernel security and bug fix update 2010-03-29 12:18:21 UTC

Description Prarit Bhargava 2009-10-06 16:11:15 UTC
Created attachment 363850 [details]
RHEL5 fix for this issue

Description of problem:

pci_dev->is_enabled is not set in RHEL5.4.   This may cause some devices suspend/resume to fail.

Version-Release number of selected component (if applicable): 2.6.18-164.el5


How reproducible: 100%


Additional info: We haven't seen a problem, but the variable needs to be set in order for code to work properly.

Comment 1 Prarit Bhargava 2009-10-06 16:16:06 UTC
Created attachment 363851 [details]
RHEL5 fix for this issue

Comment 2 RHEL Program Management 2009-10-06 17:17:46 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 4 Don Zickus 2009-10-21 19:13:43 UTC
in kernel-2.6.18-170.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Please do NOT transition this bugzilla state to VERIFIED until our QE team
has sent specific instructions indicating when to do so.  However feel free
to provide a comment indicating that this fix has been verified.

Comment 7 Petr Beňas 2010-03-16 12:54:53 UTC
 drivers/pci/pci.c on 2.6.18-192.el5:
 710         if (dev->is_enabled)
 711                 return 0;               /* already enabled */
 712 
 713         for (i = 0; i < DEVICE_COUNT_RESOURCE; i++)
 714                 if (dev->resource[i].flags & flags)
 715                         bars |= (1 << i);

On 2.6.18-192.el5:
 710         if (dev->is_enabled)
 711                 return 0;               /* already enabled */
 712 
 713         dev->is_enabled = 1; <-------------- here it is
 714 
 715         for (i = 0; i < DEVICE_COUNT_RESOURCE; i++)
 716                 if (dev->resource[i].flags & flags)
 717                         bars |= (1 << i);

Comment 9 errata-xmlrpc 2010-03-30 07:38:56 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html


Note You need to log in before you can comment on or make changes to this bug.