Bug 527498 - Bashisms in init scripts and upstart job
Summary: Bashisms in init scripts and upstart job
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: readahead
Version: 12
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Harald Hoyer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-06 16:46 UTC by Raphael Geissert
Modified: 2010-04-09 04:10 UTC (History)
1 user (show)

Fixed In Version: readahead-1.5.6-1.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-24 15:33:36 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
patch (2.63 KB, patch)
2009-10-06 16:47 UTC, Raphael Geissert
no flags Details | Diff

Description Raphael Geissert 2009-10-06 16:46:21 UTC
The attached patch fixes some insignificant bashisms in the init scripts, and a couple of bashisms in the upstart job.

Comment 1 Raphael Geissert 2009-10-06 16:47:33 UTC
Created attachment 363855 [details]
patch

Again, it failed to attach the file when submitting the bug. Sorry for the extra noise.

Comment 2 Harald Hoyer 2009-10-06 16:53:22 UTC
hmm, $"" is used for translations

Comment 3 Raphael Geissert 2009-10-07 00:44:20 UTC
Sure, but:
a) it is bash-specific, and discouraged
b) it has its security implications: http://www.gnu.org/software/gettext/manual/html_node/bash.html
c) TEXTDOMAIN is not set, so it does nothing anyway
d) partitioned strings are hard to translate in some languages
e) if really wanted, there's gettext.sh (see the link of b))
:)

Comment 4 Bug Zapper 2009-11-16 13:18:59 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 5 Fedora Update System 2010-03-24 16:16:51 UTC
readahead-1.5.6-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/readahead-1.5.6-1.fc13

Comment 6 Fedora Update System 2010-04-09 04:09:34 UTC
readahead-1.5.6-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.