Description of problem: Running ksm status without loading ksm module or kernel does not support it, it throws out errors. # /etc/init.d/ksm status cat: /sys/kernel/mm/ksm/run: No such file or directory /etc/init.d/ksm: line 69: [: -eq: unary operator expected ksm is not running Version-Release number of selected component (if applicable): qemu-common-0.11.0-3.fc12.x86_64 How reproducible: always Steps to Reproduce: 1. make sure the kernel does not have KSM enable. 2. service ksm status Actual results: untidy error messages Expected results: more meaningful error messages like "No KSM support in kernel or the module not loaded."
Thanks, here's the fix I'll push for F-12: http://gitorious.org/ksm-control-scripts/ksm-control-scripts/commit/c0b6774c9032ac3623a5d4f736707e6855e57867 Look okay to you danken?
you'd probably prefer to throw away stderr, not stdout, in $(cat /sys/kernel/mm/ksm/run &>/dev/null) ;-) and come to think of it, doing [ "$(cat /sys/kernel/mm/ksm/run &>/dev/null)" != 1 ] is a bit more robust (or should I say paranoid?).
(In reply to comment #2) > you'd probably prefer to throw away stderr, not stdout, in > $(cat /sys/kernel/mm/ksm/run &>/dev/null) > ;-) Gah, I fixed that, but forgot to include it before pushing > and come to think of it, doing > [ "$(cat /sys/kernel/mm/ksm/run &>/dev/null)" != 1 ] > is a bit more robust (or should I say paranoid?). Okay Pushed this: http://gitorious.org/ksm-control-scripts/ksm-control-scripts/commit/71db2c0ac8
* Fri Oct 9 2009 Mark McLoughlin <markmc> - 2:0.11.0-6 - Fix fs errors with virtio and qcow2 backing file (#524734) - Fix ksm initscript errors on kernel missing ksm (#527653) - Add missing Requires(post): getent, useradd, groupadd (#527087)
tag request: https://fedorahosted.org/rel-eng/ticket/2429
tagged now for F12 GA