Bug 527971 - Review Request: ocaml-react - OCaml framework for Functional Reactive Programming (FRP)
Summary: Review Request: ocaml-react - OCaml framework for Functional Reactive Program...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: William Cohen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-08 12:36 UTC by Richard W.M. Jones
Modified: 2015-09-17 00:29 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-10-12 08:31:17 UTC
Type: ---
Embargoed:
dchen: fedora-review?


Attachments (Terms of Use)

Description Richard W.M. Jones 2009-10-08 12:36:46 UTC
Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-react.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-react-0.9.0-1.fc11.src.rpm
Description: OCaml framework for Functional Reactive Programming (FRP)

Comment 1 Richard W.M. Jones 2009-10-08 12:37:11 UTC
rpmlint is silent on this package.

Comment 2 Richard W.M. Jones 2009-10-08 12:39:55 UTC
Koji scratch build is here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1735265

Comment 3 Till Maas 2009-10-08 13:01:05 UTC
Instead of %define, %global should be used nowadays.

Comment 4 Richard W.M. Jones 2009-10-08 13:13:01 UTC
Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-react.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-react-0.9.0-2.fc11.src.rpm

Changed %define -> %global.

Comment 5 William Cohen 2009-10-09 16:06:33 UTC
$ rpmlint ../RPMS/x86_64/ocaml-react-*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ocaml-react.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora BSD
+ license matches the actual package license
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
+ package successfully builds on at least one architecture
  x86_64, i686
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1735265
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
+ header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
+ -devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8
+ use %global instead of %define

Optional:

+ if there is no license file, packager should query upstream
  The LICENSE is a separate SOURCE1 file and not in SOURCE0.
  On http://erratique.ch/software/react:
     React is made of a single, independent, module and distributed under
    the new BSD license.
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock
  scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1735265
+ the package should build into binary RPMs on all supported architectures
+ review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
  /usr/sbin

Comment 6 Richard W.M. Jones 2009-10-09 16:18:58 UTC
Thanks William.  On the issue of the Source1 license, I
copied that out from the license in the react.ml source
file from the tarball.

CVS request, coming up in 3 ... 2 ... 1 ...

Comment 7 Richard W.M. Jones 2009-10-09 16:20:56 UTC
New Package CVS Request
=======================
Package Name: ocaml-react
Short Description: OCaml framework for Functional Reactive Programming (FRP)
Owners: rjones
Branches: F-12
InitialCC:

Comment 8 Kevin Fenzi 2009-10-10 22:16:38 UTC
cvs done.

Comment 10 Ding-Yi Chen 2015-09-16 05:12:30 UTC
New Package CVS Request
=======================
Package Name: ocaml-react
Short Description: OCaml framework for Functional Reactive Programming (FRP)
Owners: rjones dchne
Branches: epel7 el6
InitialCC:

Comment 11 Gwyn Ciesla 2015-09-16 12:54:30 UTC
dchne is not in the packager group.

Comment 12 William Cohen 2015-09-16 13:47:51 UTC
This is very weird. I did NOT run rpmlint or enter comment #5 (or any of the other previous comments).  Given this and comment #11 is there some corruption going on in bugzilla? -William E Cohen

Comment 13 Ding-Yi Chen 2015-09-17 00:29:41 UTC
New Package CVS Request
=======================
Package Name: ocaml-react
Short Description: OCaml framework for Functional Reactive Programming (FRP)
Owners: rjones dchen
Branches: epel7 el6


Note You need to log in before you can comment on or make changes to this bug.