Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be available on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.
Bug 528016 - smartd initscript lsb compliance
Summary: smartd initscript lsb compliance
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: smartmontools
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Michal Hlavinka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: InitScriptsProject
TreeView+ depends on / blocked
 
Reported: 2009-10-08 15:43 UTC by Yulia Kopkova
Modified: 2009-10-09 10:54 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-10-09 10:54:37 UTC
Type: ---


Attachments (Terms of Use)

Description Yulia Kopkova 2009-10-08 15:43:46 UTC
Description of problem:

According to https://fedoraproject.org/wiki/Packaging/SysVInitScript component init script have few lsb compliance issues:

1. Init scripts should return code "4" if restarting service under
nonprivileged user:

# su testuserqa -c "service smartd restart"; echo $?
Shutting down smartd:                                      [FAILED]
Starting smartd:                                           [  OK  ]
touch: cannot touch `/var/lock/subsys/smartd': Permission denied
0
now: 0
expected: 4

2. init script should return code "2" on passing invalid argument
# service smartd nonexist ; echo $?
Usage: /etc/init.d/smartd {start|stop|reload|force-reload|report|restart|try-restart|status}
3
now: 3
expected: 2 

3. condrestart action should be supported

Comment 1 Yulia Kopkova 2009-10-09 09:57:25 UTC
Michal, please add comment about the reason you have closed the bug.

Comment 2 Michal Hlavinka 2009-10-09 10:13:14 UTC
I've closed bug as closed:rawdhide, because this bug was filled against rawhide and it's fixed now. So I wonder why did you reopen this bug, is it still failing your tests?

Comment 3 Yulia Kopkova 2009-10-09 10:40:34 UTC
Thanks for quick fix! It passed my test. 

Just a note. It makes QE life easy if developer add comment about the reason closing the bug or fill "Fixed In Version" field. :)

Comment 4 Michal Hlavinka 2009-10-09 10:54:37 UTC
well, for me info about closex:XYZ statuses are enough self-descriptive with the est in https://bugzilla.redhat.com/page.cgi?id=fields.html#status , but I'll try to make your life easier next time ;-)

fixed in:
smartmontools-5.38-19.fc13
smartmontools-5.38-19.fc12
smartmontools-5.38-15.fc11


Note You need to log in before you can comment on or make changes to this bug.