Hide Forgot
Spec URL: http://akurtakov.fedorapeople.org/piccolo2d.spec SRPM URL: http://akurtakov.fedorapeople.org/piccolo2d-1.3-0.svn689.fc11.src.rpm Description: A revolutionary way to create robust, full-featured graphical applications in Java with striking visual effects such as zooming, animation and multiple representations.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1737849
I had to install maven-scm to get it to build. Also, it would be nice if all of the BRs had versions on them so that the F-11 versions (which don't work) would not be used. Also, please use an explicit svn revision when exporting and encode that revision number in the tarball name.
(In reply to comment #2) > I had to install maven-scm to get it to build. Also, it would be nice if all > of the BRs had versions on them so that the F-11 versions (which don't work) > would not be used. Fixed. > > Also, please use an explicit svn revision when exporting and encode that > revision number in the tarball name. Fixed. New sources: Spec URL: http://akurtakov.fedorapeople.org/piccolo2d.spec SRPM URL: http://akurtakov.fedorapeople.org/piccolo2d-1.3-0.svn691.1.fc11.src.rpm
Thanks. Full review below. Only one issue. - licensing fine - naming fine - version fine - release fine - builds fine - macros fine - files good except marking piccolo2d as %doc - X rpmlint output: $ rpmlint /home/overholt/rpmbuild/RPMS/noarch/piccolo2d-1.3-0.svn689.fc11.noarch.rpm piccolo2d.noarch: W: no-documentation piccolo2d.noarch: W: non-conffile-in-etc /etc/maven/fragments/piccolo2d The latter warning is okay to ignore but please mark license-piccolo.txt as %doc.
I will be on vacation starting tomorrow so in the interest of time, I appoint Jeff Johnston to approve this review when Alex comes back with an SRPM with the license file marked as %doc. Jeff, you will know that this has been fixed when you build the package and run rpmlint on the resulting binary and do _not_ get: piccolo2d.noarch: W: no-documentatio Thanks.
(In reply to comment #5) > I will be on vacation starting tomorrow so in the interest of time, I appoint > Jeff Johnston to approve this review when Alex comes back with an SRPM with the > license file marked as %doc. Jeff, you will know that this has been fixed when > you build the package and run rpmlint on the resulting binary and do _not_ get: > > piccolo2d.noarch: W: no-documentatio > > Thanks. Fixed. New sources: Spec URL: http://akurtakov.fedorapeople.org/piccolo2d.spec SRPM URL: http://akurtakov.fedorapeople.org/piccolo2d-1.3-0.svn691.2.fc11.src.rpm
Thanks, approved. Belay that request, Jeff ;)
New Package CVS Request ======================= Package Name: piccolo2d Short Description: Structured 2D graphics toolkit Owners: akurtakov Branches: F-12 InitialCC: akurtakov
cvs done.
Build in rawhide and F-12.