Bug 528651 - Wrong grub setup if /boot is a part of /
Summary: Wrong grub setup if /boot is a part of /
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Fedora
Classification: Fedora
Component: memtest86+
Version: 11
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jarod Wilson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-13 08:18 UTC by Jan ONDREJ
Modified: 2010-01-19 00:57 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-12-04 18:32:34 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch to fix this bug. (507 bytes, patch)
2009-10-13 08:18 UTC, Jan ONDREJ
no flags Details | Diff

Description Jan ONDREJ 2009-10-13 08:18:28 UTC
Created attachment 364565 [details]
Patch to fix this bug.

Description of problem:
memtest-setup does not work properly, if /boot is not a separate partition. Most of my systems does not use /boot and leave it on / (root filesystem).
Solution and patch attached.

Version-Release number of selected component (if applicable):
memtest86+-2.11-9.fc11.i586

How reproducible:
always

Steps to Reproduce:
1. install system without /boot
2. yum install memtest86+
3. memtest-setup
4. try to boot memtest
  
Actual results:
Error 13: Invalid or unsupported executable format

Press any key to continue...

Expected results:
running memtest86+

Additional info:
Here is one line shell debug output from memtest-setup:
+ sed -i '-es,kernel /elf-memtest86+,kernel --type=netbsd /elf-memtest86+,' /boot/grub/grub.conf
But I have no /elf-memtest86+*, only /boot/elf-memtest86+-2.11 .

This change should fix it:
-    sed -i -e"s,kernel /$ENAME,kernel --type=netbsd /$ENAME," /boot/grub/grub.conf
+    sed -i -e"s,kernel \(/boot\)\?/$ENAME,kernel --type=netbsd \1/$ENAME," /boot/grub/grub.conf

Comment 1 Jarod Wilson 2009-10-13 18:59:34 UTC
Not seeing any regression running on a system that does have a separate /boot, so I see no reason not to commit it. Committed to memtest86+-4.00-2, will build for rawhide and F12 updates-testing.

Comment 2 Fedora Update System 2009-10-13 19:35:25 UTC
memtest86+-4.00-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/memtest86+-4.00-2.fc12

Comment 3 Jan ONDREJ 2009-10-14 06:00:17 UTC
Please make a build for f11 too. Thank you.

Comment 4 Fedora Update System 2009-10-20 16:41:14 UTC
memtest86+-4.00-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/memtest86+-4.00-2.fc11

Comment 5 Jan ONDREJ 2009-11-18 13:29:45 UTC
Works for me.

Comment 6 Vedran Miletić 2009-12-04 18:32:34 UTC
The VERIFIED, FAILS_QA and RELEASE_PENDING bug states are not used by Fedora (they are used in the RHEL process).

---

Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 7 Fedora Update System 2010-01-19 00:57:20 UTC
memtest86+-4.00-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.