Bug 528729 - python-kid: serialization.py does not escape > to >
Summary: python-kid: serialization.py does not escape > to >
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-kid
Version: 12
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Till Maas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 633271
TreeView+ depends on / blocked
 
Reported: 2009-10-13 13:58 UTC by Till Maas
Modified: 2010-09-13 13:12 UTC (History)
3 users (show)

Fixed In Version: 0.9.6-6.el4
Clone Of:
: 633271 (view as bug list)
Environment:
Last Closed: 2010-01-26 00:52:07 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
This patch makes serialization.py escape > to > (1.14 KB, patch)
2009-10-13 13:58 UTC, Till Maas
no flags Details | Diff
Escape ]]> as ]]> (1.33 KB, patch)
2010-01-10 13:56 UTC, Till Maas
no flags Details | Diff

Description Till Maas 2009-10-13 13:58:33 UTC
Created attachment 364592 [details]
This patch makes serialization.py escape > to >

Description of problem:
Serialiazation.py does not escape > to &gt; this makes python-kid produce invalid xml, when <![CDATA[foo]]> is escaped by serialization.py.

Version-Release number of selected component (if applicable):
python-kid-0.9.6-2.fc8

How reproducible:
always

Steps to Reproduce:
1.create a python kid template that contains a variable that expands to a string containing <![CDATA[foo]]>
2. produce the xhtml 1.0 strict 
3. run xmllint on the file
  
Actual results:
xmmlint complains:
xmllint debug 
debug:197: parser error : Sequence ']]>' not allowed in content
      &lt;![CDATA[
          ^
debug:197: parser error : Sequence ']]>' not allowed in content
      ]]>
      ^
debug:197: parser error : internal error
      ]]>
      ^
debug:197: parser error : Extra content at the end of the document
      ]]>
      ^

Expected results:
xmllint does not complain

Additional info:
I will attach a patch that fixes this.

Comment 1 Bug Zapper 2009-11-18 12:17:19 UTC
This message is a reminder that Fedora 10 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 10.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '10'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 10's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 10 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 Bug Zapper 2009-12-18 09:44:52 UTC
Fedora 10 changed to end-of-life (EOL) status on 2009-12-17. Fedora 10 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 3 Till Maas 2009-12-18 10:12:55 UTC
Seems not to be fixed in F12, too.

Comment 4 Till Maas 2010-01-02 15:13:42 UTC
The bug is imho well described and a patch is attached, but I did not get any response for 2.5 months. Therefore I start the non responsive maintainer process as described here:
https://fedoraproject.org/wiki/Policy_for_nonresponsive_package_maintainers

Please respond. If you do not have time, I can also add the patch to CVS and create updates for you.

Comment 5 Konstantin Ryabitsev 2010-01-06 15:13:23 UTC
Upstream is unmaintained, so I'm not sure how much good it is to provide patches for a what seems like a dead project. If you would like to take over the ownership of the package, then absolutely feel free.

Comment 6 Till Maas 2010-01-06 15:25:07 UTC
(In reply to comment #5)
> Upstream is unmaintained, so I'm not sure how much good it is to provide
> patches for a what seems like a dead project. If you would like to take over
> the ownership of the package, then absolutely feel free.

If upstream does not fix bugs, then there is no other way than to fix it in Fedora. I can take ownership, but I guess since he is a co-maintainer, Toshio will get ownership of the package, if you release ownership.

Toshio, what's your opinion about the patch and do you want to become owner of python-kid?

Comment 7 Toshio Ernie Kuratomi 2010-01-08 04:19:12 UTC
I agree with icon about upstream and patches.  If you want to take over maintenance of python-kid, I'll be happy to set you as the owner.

Comment 8 Till Maas 2010-01-10 13:56:08 UTC
Created attachment 382805 [details]
Escape ]]> as ]]&gt;

I updated the patch as I included iit in CVS and modified it to only escape ]]> to ]]&gt;, which was what the XML standard requires:
http://www.w3.org/TR/2006/REC-xml11-20060816/#syntax

Comment 9 Fedora Update System 2010-01-12 23:26:53 UTC
python-kid-0.9.6-6.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-kid'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0475

Comment 10 Fedora Update System 2010-01-12 23:42:03 UTC
python-kid-0.9.6-6.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-kid'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0453

Comment 11 Fedora Update System 2010-01-12 23:54:56 UTC
python-kid-0.9.6-6.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-kid'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-0049

Comment 12 Fedora Update System 2010-01-12 23:55:20 UTC
python-kid-0.9.6-6.el4 has been pushed to the Fedora EPEL 4 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-kid'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-4/FEDORA-EPEL-2010-0044

Comment 13 Fedora Update System 2010-01-26 00:52:02 UTC
python-kid-0.9.6-6.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2010-01-26 00:54:21 UTC
python-kid-0.9.6-6.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2010-02-03 20:03:45 UTC
python-kid-0.9.6-6.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2010-02-03 20:06:59 UTC
python-kid-0.9.6-6.el4 has been pushed to the Fedora EPEL 4 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.