Bug 528927 - Tiny memory leak in bridge iptables code
Summary: Tiny memory leak in bridge iptables code
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: netcf
Version: 12
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: David Lutterkort
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-14 12:11 UTC by Daniel Berrangé
Modified: 2013-04-30 23:41 UTC (History)
2 users (show)

Fixed In Version: netcf-0.1.7-1.fc14
Clone Of:
Environment:
Last Closed: 2010-10-15 12:43:53 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Daniel Berrangé 2009-10-14 12:11:52 UTC
Description of problem:
Running libvirtd under valgrind I noticed it was reporting a memory leak in netcf. After rebuilding netcf with debugging, I got this useful trace


==22894== 45 bytes in 1 blocks are definitely lost in loss record 11 of 30
==22894==    at 0x4006F3D: malloc (vg_replace_malloc.c:207)
==22894==    by 0xAA4B07: vasprintf (in /lib/libc-2.10.1.so)
==22894==    by 0x4012613: xasprintf (dutil.c:62)
==22894==    by 0x4014213: bridge_nf_call_iptables (dutil_linux.c:161)
==22894==    by 0x400FEF1: bridge_physdevs (drv_initscripts.c:360)
==22894==    by 0x401071B: drv_init (drv_initscripts.c:488)
==22894==    by 0x400E401: ncf_init (netcf.c:98)
==22894==    by 0x804A335: main (ncftool.c:755)

Looks like the 

    char *path = NULL;

variable isn't being freed upon successful completion



Version-Release number of selected component (if applicable):
netcf-0.1.2-1.fc13.i386

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Bug Zapper 2009-11-16 13:40:04 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 Fedora Update System 2010-09-27 17:14:58 UTC
netcf-0.1.7-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/netcf-0.1.7-1.fc14

Comment 3 Fedora Update System 2010-09-27 17:17:08 UTC
netcf-0.1.7-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/netcf-0.1.7-1.fc13

Comment 4 Fedora Update System 2010-09-27 17:18:28 UTC
netcf-0.1.7-1.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/netcf-0.1.7-1.fc12

Comment 5 Fedora Update System 2010-09-27 20:09:05 UTC
netcf-0.1.7-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update netcf'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/netcf-0.1.7-1.fc14

Comment 6 Fedora Update System 2010-10-14 23:03:49 UTC
netcf-0.1.7-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2010-10-14 23:05:49 UTC
netcf-0.1.7-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2010-10-15 12:43:31 UTC
netcf-0.1.7-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.