Spec URL: http://guidograzioli.fedorapeople.org/packages/yaml-cpp/yaml-cpp.spec SRPM URL: http://guidograzioli.fedorapeople.org/packages/yaml-cpp/yaml-cpp-0.2.2-1.fc11.src.rpm Description: yaml-cpp is a YAML parser and emitter in C++ written around the YAML 1.2 spec.
Guido, the package is pretty clean. You should just remove the duplicate license.txt from devel. It's sufficient to add it to the base package. $ rpmlint /var/lib/mock/fedora-11-x86_64/result/yaml-cpp-* 4 packages and 0 specfiles checked; 0 errors, 0 warnings. --------------------------------- keys used in following checklist: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. - MIT (modern style with sublicense) according to license.txt [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ sha1sum yaml-cpp-0.2.2.tar.gz* b239e50fed91a11ada843646622df84c69fea297 yaml-cpp-0.2.2.tar.gz b239e50fed91a11ada843646622df84c69fea297 yaml-cpp-0.2.2.tar.gz.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1750413 [.] MUST: If the package does not successfully compile, build or work ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. - no locales [+] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [.] MUST: If the package is designed to be relocatable, ... - not relocatable [+] MUST: A package must own all directories that it creates. [X] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. - remove license.txt from %doc of devel package [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot}. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. - no large docs [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. - no static libs built [+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' [+] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [+] MUST: devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [+] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. .la files removed [.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. - no GUI [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}. [+] MUST: All filenames in rpm packages must be valid UTF-8. [+] SHOULD: The reviewer should test that the package builds in mock. - builds in mock [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. - builds in koji [+] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. - seems to work as expected [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
Ok, here are the updated files: http://guidograzioli.fedorapeople.org/packages/yaml-cpp/ rpmlint issues a W: no-doc for the -devel package now, but there's actually nothing i can put there as for now.
OK, fine. The rpmlint warning can actually be ignored, and I found no further things to complain about. :) ------------------------ The package is APPROVED. ------------------------
Thanks for the review. New Package CVS Request ======================= Package Name: yaml-cpp Short Description: A YAML parser and emitter for C++ Owners: guidograzioli Branches: F-11 F-12 InitialCC:
cvs done.
yaml-cpp-0.2.2-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/yaml-cpp-0.2.2-2.fc11
yaml-cpp-0.2.2-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/yaml-cpp-0.2.2-2.fc12
yaml-cpp-0.2.2-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update yaml-cpp'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10692
yaml-cpp-0.2.2-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: yaml-cpp New Branches: el6 Owners: hobbes1069 InitialCC:
Git done (by process-git-requests).
Package Change Request ====================== Package Name: yaml-cpp New Branches: epel7 Owners: mskalick
Comments from primary maintainers?
It would have been nice to be asked to support an EPEL 7 branch first but I don't have any problem with it. I would ask to be added as an owner though.
(In reply to Richard Shaw from comment #14) > It would have been nice to be asked to support an EPEL 7 branch first but I > don't have any problem with it. I would ask to be added as an owner though. I am sorry I somehow overlooked the comment about this in https://fedoraproject.org/wiki/Package_SCM_admin_requests. yaml-cpp is required by mongodb, so could you please include it in epel7?
Package Change Request ====================== Package Name: yaml-cpp New Branches: epel7 Owners: hobbes1069 InitialCC: mskalick
yaml-cpp-0.5.1-6.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/yaml-cpp-0.5.1-6.el7
yaml-cpp-0.5.1-6.el7 has been pushed to the Fedora EPEL 7 stable repository.