phploc is a tool for quickly measuring the size of a PHP project. The goal of phploc is not not to replace more sophisticated tools such as phpcs, pdepend, or phpmd, but rather to provide an alternative to them when you just need to get a quick understanding of a project's size. --- SPEC: http://llaumgui.fedorapeople.org/review/phploc.spec SRPM: http://llaumgui.fedorapeople.org/review/phploc-1.2.0-1.fc11.src.rpm RPM: http://llaumgui.fedorapeople.org/review/phploc-1.2.0-1.fc11.noarch.rpm --- rpmlint: phploc.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Pear CompatInfo: +-----------------------------+---------+---+------------+--------------------+ | Files | Version | C | Extensions | Constants/Tokens | +-----------------------------+---------+---+------------+--------------------+ | ./* | 5.0.0 | 1 | tokenizer | catch | | | | | | protected | | | | | | public | | | | | | throw | | | | | | try | +-----------------------------+---------+---+------------+--------------------+
rename php-pear-phploc SPEC: http://llaumgui.fedorapeople.org/review/php-pear-phploc.spec SRPM: http://llaumgui.fedorapeople.org/review/php-pear-phploc-1.2.0-1.fc11.src.rpm RPM: http://llaumgui.fedorapeople.org/review/php-pear-phploc-1.2.0-1.fc11.noarch.rpm
According to PHP Guidelines, as this package come from PHPUnit, it should be named php-phpunit-phploc + P.S. yes I know php-pear-PHPUnit is not named correctly ;) but it's a old package (before Guidelines was written, and available in PEAR channel at this time)
Thx remi, Done : SPEC: http://llaumgui.fedorapeople.org/review/php-phpunit-phploc.spec SRPM: http://llaumgui.fedorapeople.org/review/php-phpunit-phploc-1.2.0-1.fc11.src.rpm RPM: http://llaumgui.fedorapeople.org/review/php-phpunit-phploc-1.2.0-1.fc11.noarch.rpm
OK: rpmlint must be run on every package. The output should be posted in the review. php-phpunit-phploc.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. . OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK: Packages must NOT bundle copies of system libraries. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK: All filenames in rpm packages must be valid UTF-8. looks good to me: ACCEPT
New Package CVS Request ======================= Package Name: php-phpunit-phploc Short Description: A tool for quickly measuring the size of a PHP project Owners: llaumgui cdamian Branches: F-10 F-11 F-12 EL-5 InitialCC:
cvs done.
Package Change Request ====================== Package Name: php-phpunit-phploc New Branches: EL-6 Owners: llaumgui
There is already a EL-6 branch. ;)