Wrt to the text: 'Install to hard drive' sounds a little technical and more importantly, does not mention Fedora at all. We'd like to see it replaced by 'Install Fedora 12'. If that is not desirable because of the version dependency, 'Install Fedora' would still be much better than 'Install to hard drive'. Wrt to the icon: The current icon shows a box and a cd. That can be a bit misleading, since you may run the live cd off a usb stick, and it does not show the installation target at all. We'd like to have an icon that is based on the hard disk icon that we use throughout the desktop. Jon will try to come up with a proposal.
If you've got an icon, please attach it or a link to it here and I'll gladly update the desktop.in file to match. As for this bug in general - I'm fine with updating these items, but keep in mind that it's unlikely to get fixed in F12 because of the string break and because this isn't an F12Blocker.
Created attachment 366489 [details] install to disk icon
Created attachment 366490 [details] source for install to disk icon
Hey Chris, the new PNG is in comment 2, me and msourada worked on it.
As per discussion on IRC, adding to blocker list so it's looked at before release. This clearly shouldn't *block* the release, but if another blocker needs to go in this one should probably go in, too, because it will make the release that much more polished with low risk.
can we have a 'before' picture so we know exactly the change we're looking at here? -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
actually, moving this fedora-logos, because I don't *think* anaconda will need to be changed at all. We just call it /usr/share/icons/Fedora/48x48/apps/system-software-install.png and /usr/share/icons/Fedora/scalable/apps/system-software-install.svg and everything should just work.
This is built as fedora-logos-12.0.2-2.fc12, awaiting rel-eng tagging.
Tagged in F-12 and built in rawhide, closing.
Grr, I take back my words. Icons do have risk :-( The decision to reuse the same icon name was a bad one, since now gpk-application shows up with the installer icon in the menus, which is really not what was intended here. So, I think we need to a) add the new icon with a new name b) change the desktop file in anaconda to use the new icon
fedora-logos-12.0.3-1.fc12 is tagged, the files are now named "anaconda.png" and "anaconda.svg", in the same paths.
Discussed at the blocker meeting today. We can take a fix for this as long as it doesn't delay the next anaconda build. Anaconda team, just needs patching to use 'anaconda' as the icon name in the appropriate place. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
Patch tested and submitted to anaconda list for the liveinst .desktop file. I've also asked spot to build generic-logos with an 'anaconda' image in it too so that we don't break the de-branded case.
this is in the 12.42 build: http://koji.fedoraproject.org/koji/buildinfo?buildID=139122 tag request: https://fedorahosted.org/rel-eng/ticket/2942 -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
This should be in tomorrow's (20091103) rawhide - please retest with that.
the new icon is confirmed working - I just span a live image to test something else, it happened to get anaconda 12.42, and the new icon is there. Add/Remove Software has the correct icon (not the one intended for anaconda). I note the string change hasn't been done, I guess because of the freeze, so we should probably leave the bug open. But the icon part is fixed, so dropping this from the blocker list. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
This breaks the KDE Live image, as the new icon is only in the Fedora theme and not in anything inherited by the Fedora-KDE theme. The icon must be moved to the common hicolor theme.
This change makes the KDE Live image no longer show a liveinst icon on the desktop => blocker.
I just asked spot (in #fedora-devel) to add to Fedora-kde theme too. For posterity, I'd think adding fedora-logo icons to hicolor theme would be a safer thing to do.
Should be fixed in fedora-logos-12.0.3-2.fc12 http://cvs.fedoraproject.org/viewvc/rpms/fedora-logos/F-12/fedora-logos.spec?r1=1.136&r2=1.137
fwiw, that's my fault. I told spot to put it in the Fedora theme originally, only to realize I should have told him hicolor 10 minutes after he pushed the build. I didn't think it would matter in practice, so I told him not to worry about doing a new build.
tag request: https://fedorahosted.org/rel-eng/ticket/3102 it does occur to me to wonder whether this is going to turn out to be broken in all the other desktop spins, too... -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
The current fix just adds the icon to Fedora-KDE too, but if spins are using other themes than Fedora or Fedora-KDE, it still won't work for them. Maybe the safest is to just move the icon to hicolor instead?
hicolor is definitely the "right" place for it to go.
<nirik> adamw: in case you didn't figure it already, Xfce uses Nodoka. <adamw> nirik: does it inherit from Fedora? <nirik> yes. <adamw> whew. should be okay then, I think. still building an image to check. do you know what lxde does? <nirik> not sure off hand. ;( -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
I tested to confirm: an xfce build with fedora-logos-12.0.3-2.fc12 and a recent anaconda shows an icon on the desktop, and it's the right icon (the nice new one). I'll test lxde later today or tomorrow. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
Just tested LXDE. It's fine. Closing! -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers