Bug 529542 - Review Request: php-phpunit-phpcpd - Copy/Paste Detector (CPD) for PHP code
Summary: Review Request: php-phpunit-phpcpd - Copy/Paste Detector (CPD) for PHP code
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 11
Hardware: noarch
OS: Linux
low
medium
Target Milestone: ---
Assignee: Christof Damian
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-18 13:21 UTC by Guillaume Kulakowski
Modified: 2010-10-19 03:55 UTC (History)
4 users (show)

Fixed In Version: 1.2.0-1.fc11
Clone Of:
Environment:
Last Closed: 2009-12-04 23:56:00 UTC
Type: ---
Embargoed:
christof: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Guillaume Kulakowski 2009-10-18 13:21:15 UTC
phpcpd is a Copy/Paste Detector (CPD) for PHP code.

The goal of phpcpd is not not to replace more sophisticated tools such as phpcs,
pdepend, or phpmd, but rather to provide an alternative to them when you just
need to get a quick overview of duplicated code in a project.

---

SPEC:
http://llaumgui.fedorapeople.org/review/phpcpd.spec

SRPM:
http://llaumgui.fedorapeople.org/review/php-phpunit-phpcpd-1.2.0-1.fc11.src.rpm

RPM:
http://llaumgui.fedorapeople.org/review/php-phpunit-phpcpd-1.2.0-1.fc11.noarch.rpm

---

rpmlint:
php-phpunit-phpcpd.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

---

Pear CompatInfo:
+-----------------------------+---------+---+------------+--------------------+
| Files                       | Version | C | Extensions | Constants/Tokens   |
+-----------------------------+---------+---+------------+--------------------+
| ./*                         | 5.0.0   | 0 | hash       | ...CTORY_SEPARATOR |
|                             |         |   | tokenizer  | PATH_SEPARATOR     |
|                             |         |   | xml        | __FILE__           |
|                             |         |   |            | abstract           |
|                             |         |   |            | catch              |
|                             |         |   |            | implements         |
|                             |         |   |            | protected          |
|                             |         |   |            | public             |
|                             |         |   |            | throw              |
|                             |         |   |            | try                |
+-----------------------------+---------+---+------------+--------------------+

Comment 1 Guillaume Kulakowski 2009-10-18 13:30:21 UTC
Sorry, spec file is here : http://llaumgui.fedorapeople.org/review/php-phpunit-phpcpd.spec

Comment 2 Guillaume Kulakowski 2009-11-07 18:10:58 UTC
SPEC updated : http://llaumgui.fedorapeople.org/review/php-phpunit-phpcpd.spec

Comment 3 Christof Damian 2009-11-13 11:51:35 UTC
OK: rpmlint must be run on every package. The output should be posted in the review.

    php-phpunit-phpcpd.noarch: W: no-documentation
    2 packages and 0 specfiles checked; 0 errors, 1 warnings.

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.  .
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK: The License field in the package spec file must match the actual license. 
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. 
OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A Fedora package must not list a file more than once in the spec file's %files listings. 
OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. 
OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
OK: All filenames in rpm packages must be valid UTF-8.

Comment 4 Guillaume Kulakowski 2009-11-16 09:16:02 UTC
@Christof Damian > You approve ? If you approve, please add a line like :

-------------------------------------------------------------------
    This package (php-phpunit-phpcpd) is APPROVED by Christof Damian
-------------------------------------------------------------------

Comment 5 Christof Damian 2009-11-16 10:01:58 UTC
This package (php-phpunit-phpcpd) is APPROVED by Christof Damian

Comment 6 Guillaume Kulakowski 2009-11-16 10:22:40 UTC
New Package CVS Request
=======================
Package Name: php-phpunit-phpcpd
Short Description: Copy/Paste Detector (CPD) for PHP code
Owners: llaumgui cdamian
Branches: F-10 F-11 F-12
InitialCC:

Comment 7 Jason Tibbitts 2009-11-16 17:52:34 UTC
CVS done.

Comment 8 Fedora Update System 2009-11-18 11:52:56 UTC
php-phpunit-phpcpd-1.2.0-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/php-phpunit-phpcpd-1.2.0-1.fc11

Comment 9 Fedora Update System 2009-11-18 11:53:01 UTC
php-phpunit-phpcpd-1.2.0-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/php-phpunit-phpcpd-1.2.0-1.fc10

Comment 10 Fedora Update System 2009-11-18 11:53:07 UTC
php-phpunit-phpcpd-1.2.0-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/php-phpunit-phpcpd-1.2.0-1.fc12

Comment 11 Fedora Update System 2009-11-20 05:14:50 UTC
php-phpunit-phpcpd-1.2.0-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-phpunit-phpcpd'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-11738

Comment 12 Fedora Update System 2009-11-20 05:29:46 UTC
php-phpunit-phpcpd-1.2.0-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-phpunit-phpcpd'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-11821

Comment 13 Fedora Update System 2009-11-20 05:37:44 UTC
php-phpunit-phpcpd-1.2.0-1.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-phpunit-phpcpd'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-11864

Comment 14 Fedora Update System 2009-12-04 23:55:55 UTC
php-phpunit-phpcpd-1.2.0-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2009-12-05 00:00:24 UTC
php-phpunit-phpcpd-1.2.0-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2009-12-05 00:06:46 UTC
php-phpunit-phpcpd-1.2.0-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Guillaume Kulakowski 2010-09-04 15:14:15 UTC
Package Change Request
======================
Package Name: php-phpunit-File-Iterator
New Branches: EL-6
Owners: llaumgui

Comment 18 Kevin Fenzi 2010-09-05 17:40:08 UTC
There is already a EL-6 branch.

Comment 19 Christof Damian 2010-10-17 13:30:04 UTC
Package Change Request
======================
Package Name: php-phpunit-phpcpd
New Branches: el6
Owners: llaumgui cdamian

I guess the last request was a typo

Comment 20 Kevin Fenzi 2010-10-19 03:55:03 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.