Bug 529648 - Openoffice crash saving on SMB shares
Summary: Openoffice crash saving on SMB shares
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: openoffice.org
Version: 11
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: David Tardon
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 529915 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-19 10:31 UTC by Davide Repetto
Modified: 2010-03-01 16:52 UTC (History)
5 users (show)

Fixed In Version: 3.1.1-19.12.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-16 13:24:14 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
OpenOffice Crash Log (10.96 KB, text/plain)
2009-10-19 10:31 UTC, Davide Repetto
no flags Details
standalone testcase (2.91 KB, text/plain)
2009-11-11 14:48 UTC, David Tardon
no flags Details
Error Dialog (9.23 KB, image/png)
2010-03-01 16:52 UTC, Davide Repetto
no flags Details


Links
System ID Private Priority Status Summary Last Updated
OpenOffice.org 104974 0 None None None Never
OpenOffice.org 106591 0 None None None Never

Description Davide Repetto 2009-10-19 10:31:40 UTC
Created attachment 365225 [details]
OpenOffice Crash Log

Description of problem:
=======================
Openoffice (any program) crashes when saving a document. (on SMB shares)

**** The crash happens if you're saving on an SMB share
     (a samba server in my case).
**** The crash happens only if you're saving an already existing document.
     The initial save works.

In the same situation previous versions of Oo would issue a waring about not
being able to save a backup and then the file would get saved the next time you
hit the "save" button. This was a known problem.

With 3.1.1 you simply get a crash instead.


Versions:
=========
openoffice.org-base-3.1.1-19.2.fc11.i586


Crashlog from openoffice:
=========================
See the Attached File

How reproducible:
=================
Always


Steps to Reproduce:
===================
1. Create a document. Or open an existing one.
2. If you Save it on an SMB share for the first time (and the file does not yet
exist on the SMB share) it should work
3. If the file already exists when you hit "Save", then Openoffice should crash


Actual results:
===============
Crash with pop-up "OOo has crashed! Paste this text into your bugreport"


Expected results:
=================
If not a flawless save, one would expect at least the old behaviour (with
warnings etc).


Additional info:
================

I mount my samba shares through fstab:
======================================
//smb/work  /net/work  cifs
user=testuser,pass=testpass,domain=WORKGROUP,uid=testuser,gid=users 0  


Excerpt from my samba config:
=============================

[global]
        time server = Yes
        unix extensions = No
        ^^^^^^^^^^^^^^^^^^^^
        domain logons = Yes
        preferred master = Yes
        domain master = Yes
        create mask = 0770
        directory mask = 0770
        delete readonly = Yes
        dos filemode = Yes

[work]
        path = /work
        admin users = testuser
        read only = No
        force create mode = 0770
        force directory mode = 0770

Comment 1 David Tardon 2009-10-19 10:47:36 UTC
dtardon->red: could you give us result of

stat -Z /work/whatever/the/file/name.is

and

stat -Z `dirname /work/whatever/the/file/name.is`

? (subsitute the made up path for a real path)

Comment 2 Davide Repetto 2009-10-19 11:07:13 UTC
> dtardon->red: could you give us result of
 
ReD -> dtardon: I guess not. Selinux is disabled.

Comment 3 David Tardon 2009-10-19 11:17:19 UTC
dtardon->red: remove the '-Z' option, then (though i always thought that worked without selinux too)

Comment 4 Davide Repetto 2009-10-19 11:27:37 UTC
This is from my machine and the file is the latest I worked on.

==
$ stat '/net/programmi/Documenti/Lettere/Palenzona/Riscaldamento 2009.odt'
  File: `/net/programmi/Documenti/Lettere/Palenzona/Riscaldamento 2009.odt'
  Size: 35876     	Blocks: 72         IO Block: 16384  regular file
Device: 18h/24d	Inode: 6801138     Links: 1
Access: (2767/-rwxrwSrwx)  Uid: (  500/  davide)   Gid: (  100/   users)
Access: 2009-10-19 10:58:45.052294000 +0200
Modify: 2009-10-19 11:20:49.435843000 +0200
Change: 2009-10-19 11:20:49.435843000 +0200

==
$ stat /net/programmi/Documenti/Lettere/Palenzona
  File: `/net/programmi/Documenti/Lettere/Palenzona'
  Size: 0         	Blocks: 0          IO Block: 16384  directory
Device: 18h/24d	Inode: 6800243     Links: 1
Access: (0777/drwxrwxrwx)  Uid: (  500/  davide)   Gid: (  100/   users)
Access: 2009-09-11 12:29:11.296133000 +0200
Modify: 2009-10-19 11:35:16.672051600 +0200
Change: 2009-10-19 11:35:16.672051600 +0200


ADDITIONAL NOTE:
I noticed that the first "save" after recovering the documents from the crash works.

Comment 5 Davide Repetto 2009-10-19 11:39:37 UTC
For you reference:

Above I mistakenly documented the configuration of the SMB share [work]
instead of [programmi]. Anyway they are identical.

===========
[programmi]
        path = /programmi
        admin users = davide
        read only = No
        force create mode = 0770
        force directory mode = 0770
===========

Comment 6 Davide Repetto 2009-10-19 11:41:48 UTC
And this one is mounted as:

//smb/work  /net/work  cifs
user=davide,pass=*******,domain=WORKGROUP,uid=davide,gid=users 0

Comment 7 David Tardon 2009-10-19 11:59:18 UTC
ok, reproduced

Comment 8 Davide Repetto 2009-10-19 18:00:25 UTC
Thanks!

BTW, has anyone got any thoughts for a temporary workaround?

Comment 9 Caolan McNamara 2009-10-20 18:46:45 UTC
*** Bug 529915 has been marked as a duplicate of this bug. ***

Comment 10 Caolan McNamara 2009-10-20 18:47:43 UTC
No such reports ever until recently and then a few come along together ?, hmm did something get updated recently which has trigged this

Comment 11 Igor A Tarasov 2009-10-21 10:21:53 UTC
Yes, this bug is still replicating.

Comment 12 Caolan McNamara 2009-11-11 14:11:45 UTC
Is this dying *inside* a syscall, or is there a previous syscall which is returning an error that we're ignoring or something. i.e. is this our fault or can a small standalone demo be created that demonstrates samba client/server bustage ?

Comment 13 David Tardon 2009-11-11 14:46:37 UTC
dtardon->caolanm: As I said in the upstream bug, I think the problem is in mmap. I've been able to get a crash on SIGBUS by truncating the source file, but AFAIK that's documented behaviour...

I.e. compile the following attachment and run it as

./save -t /source/file /destination/file

(it crashes on copying from anywhere, not just from samba share, of course...)

Comment 14 David Tardon 2009-11-11 14:48:51 UTC
Created attachment 369037 [details]
standalone testcase

Comment 15 Caolan McNamara 2009-12-15 13:08:01 UTC
Well, lets try the current upstream idea on this one, minus the hackery to detect a bad mmap and just use read/write. Will try that for >= 3.1.1-19.11.f11

Comment 16 Fedora Update System 2009-12-17 08:54:42 UTC
openoffice.org-3.1.1-19.11.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/openoffice.org-3.1.1-19.11.fc11

Comment 17 Fedora Update System 2009-12-18 04:47:32 UTC
openoffice.org-3.1.1-19.11.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update openoffice.org'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-13396

Comment 18 Davide Repetto 2010-01-08 12:04:20 UTC
The same problem happens with openoffice.org-base-3.1.1-19.14.fc12.i686.
What is strange is that abrt doesn't catch it.

Comment 19 Romain LE DISEZ 2010-01-08 12:22:37 UTC
(In reply to comment #18)
> The same problem happens with openoffice.org-base-3.1.1-19.14.fc12.i686.
> What is strange is that abrt doesn't catch it.  

Same for me on FC12 x86_64. And OOo doesn't show me the crash dialog, it just "disappears"

Comment 20 Fedora Update System 2010-02-13 11:56:17 UTC
openoffice.org-3.1.1-19.12.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/openoffice.org-3.1.1-19.12.fc11

Comment 21 Fedora Update System 2010-02-16 13:23:35 UTC
openoffice.org-3.1.1-19.12.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 22 Davide Repetto 2010-03-01 16:52:35 UTC
Created attachment 397120 [details]
Error Dialog

OK. I'm testing the latest OpenOffice on Fedora 12 and the behaviour has changed.
Now every time I try to save a modified document on an SMB share, this message pops up and nothing get saved.

Versions:
openoffice.org-base-3.1.1-19.26.fc12.i686
openoffice.org-calc-3.1.1-19.26.fc12.i686


Note You need to log in before you can comment on or make changes to this bug.