Spec URL: http://mmaslano.fedorapeople.org/review/perl-MooseX-CascadeClearing.spec SRPM URL: http://mmaslano.fedorapeople.org/review/perl-MooseX-CascadeClearing-0.02-1.fc12.src.rpm Description: MooseX::CascadeClearing does the necessary metaclass fiddling to allow an clearing one attribute to be cascaded through to other attributes as well, calling their clearers. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1756178
And build which really passed http://koji.fedoraproject.org/koji/taskinfo?taskID=1756184
I will do this review today.
============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/i386 [x] Rpmlint output: empty [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPLv2 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. $ sha256sum MooseX-CascadeClearing-0.02.tar.gz d045d2c4aaa83ab55c1bc4413f800a0f33e0fcbd3df493e12a259d59634be364 [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: koji scratch build [x] Package should compile and build into binary rpms on all supported architectures. Tested on:koji scratch build [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the tests pass ================ *** APPROVED *** ================
New Package CVS Request ======================= Package Name: perl-MooseX-CascadeClearing Short Description: Cascade clearer actions across attributes Owners: mmaslano Branches: F-12 InitialCC: perl-sig
cvs done.
Could you add F-12 branch? I've got only devel. New Package CVS Request ======================= Package Name: perl-MooseX-CascadeClearing Short Description: Cascade clearer actions across attributes Owners: mmaslano Branches: F-12 InitialCC: perl-sig
sorry about that. It was fine in pkgdb, but didn't make the branch on the server for some reason. Should be fixed now.
Thank you.