Bug 529816 - Review Request: perl-Graphics-ColorNames-WWW - WWW color names and equivalent RGB values
Summary: Review Request: perl-Graphics-ColorNames-WWW - WWW color names and equivalent...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-20 08:45 UTC by Emmanuel Seyman
Modified: 2010-02-01 01:15 UTC (History)
2 users (show)

Fixed In Version: 1.13-1.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-01 01:03:26 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2009-10-20 08:45:08 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Graphics-ColorNames-WWW/perl-Graphics-ColorNames-WWW.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Graphics-ColorNames-WWW/perl-Graphics-ColorNames-WWW.spec
Description:
This modules defines color names and their associated RGB values from
various WWW specifications and implementations.

Comment 3 Marcela Mašláňová 2010-01-22 09:20:56 UTC
OK rpmlint on every package.
OK name of package accords to the Naming Guidelines.
OK spec file name match the base package %{name}.
OK package meet the Packaging Guidelines.
OK package has a good license.
OK spec file is written in American English.
OK spec file for the package must be legible.
FAILThe sources used to build the package must match the upstream source.
md5sum not matching
OK successful koji compilation.
OK correct BuildRequires, Requires.
OK proper use of %find_lang macro.
OK shared library must call ldconfig in %post and %postun.
OK relocatable package must state this fact.
OK package must own their directories.
OK permissions on files must be set properly.
OK %clean section with rm -rf %{buildroot}.
OK consistent use of macros.
OK package contains code, or permissable content.
OK large documentation go in a -doc subpackage.
OK %doc must not affect the runtime of the application.
OK header files must be in a -devel package.
OK static libraries must be in a -static package.
OK pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK library files with a suffix (.so) must go in -devel.
OK usually devel packages must require the base package.
OK Remove .la libtool archives.
OK GUI applications must include a %{name}.desktop file.
OK %install section starts with rm -rf %{buildroot}.

Comment 4 Emmanuel Seyman 2010-01-22 09:47:56 UTC
(In reply to comment #3)
>
> FAILThe sources used to build the package must match the upstream source.
> md5sum not matching

I went back to my local copy to confirm this, only to realize that I had updated it to 1.13 a while back. Updating the proposed package.

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Graphics-ColorNames-WWW/perl-Graphics-ColorNames-WWW.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Graphics-ColorNames-WWW/perl-Graphics-ColorNames-WWW-1.13-1.fc12.src.rpm

Comment 5 Marcela Mašláňová 2010-01-22 11:17:22 UTC
ACCEPT

Comment 6 Marcela Mašláňová 2010-01-22 11:22:35 UTC
btw don't you want do some of my perl review? 550067,553127,553142,556404 ;-)

Comment 7 Emmanuel Seyman 2010-01-22 15:30:33 UTC
(In reply to comment #5)
>
> ACCEPT    

Thanks, Marcela. Requesting CVS.

New Package CVS Request
=======================
Package Name: perl-Graphics-ColorNames-WWW
Short Description: WWW color names and equivalent RGB values
Owners: eseyman
Branches: F-11 F-12
InitialCC: perl-sig

Comment 8 Jason Tibbitts 2010-01-22 16:54:06 UTC
CVS done (by process-cvs-requests.py).

Comment 9 Fedora Update System 2010-01-22 20:23:54 UTC
perl-Graphics-ColorNames-WWW-1.13-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/perl-Graphics-ColorNames-WWW-1.13-1.fc12

Comment 10 Fedora Update System 2010-01-22 20:23:59 UTC
perl-Graphics-ColorNames-WWW-1.13-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-Graphics-ColorNames-WWW-1.13-1.fc11

Comment 11 Fedora Update System 2010-01-26 00:55:38 UTC
perl-Graphics-ColorNames-WWW-1.13-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Graphics-ColorNames-WWW'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0989

Comment 12 Fedora Update System 2010-01-26 01:02:32 UTC
perl-Graphics-ColorNames-WWW-1.13-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Graphics-ColorNames-WWW'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1051

Comment 13 Fedora Update System 2010-02-01 01:03:19 UTC
perl-Graphics-ColorNames-WWW-1.13-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2010-02-01 01:15:39 UTC
perl-Graphics-ColorNames-WWW-1.13-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.