Spec URL: http://orion.lcg.ufrj.br/RPMS/SPECS/mingw32-tk.spec SRPM URL: http://orion.lcg.ufrj.br/RPMS/src/mingw32-tk-8.5.7-5.fc10.1.src.rpm Description: This is tk for the mingw32 suite. The spec needs some tweaks, but I think it is a good starting point. I really need this package and I'll be glad to co-maintaining it with someone more acquainted with the mingw32 packages.
This is the scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1758962
We have tk 8.5.8 in F13/F14 and 8.5.9 in rawhide. Since mingw32 versions need to closely track the native version (see http://fedoraproject.org/wiki/Packaging:MinGW#Track_Fedora_native_package_versions), would you consider updating this package to either of those versions?
It has to match the version of mingw32-tcl, which is 8.5.7 in F13/F14 http://download.fedora.redhat.com/pub/fedora/linux/releases/14/Everything/source/SRPMS/mingw32-tcl-8.5.7-7.fc12.src.rpm and 8.5.8 in F15 http://download.fedora.redhat.com/pub/fedora/linux/development/source/SRPMS/mingw32-tcl-8.5.8-1.fc15.src.rpm right?
But mingw32-tcl is out of date, so it's not following the guidelines either. I don't know if the versions have to match; I know nothing of tcl and tk, honestly; I'm just trying to clean up the old tickets. Maybe file a ticket for a mingw32-tcl update and have it block this ticket?
In fact, I was just waiting for version 8.5.9 to be available in testing for F14. mingw32-tk should have been available for Fedora since the initial release of mingw32-tcl, and ideally, with the same maintainer. I will update myngw32-tk to 8.5.9 and post the .src.rpm here. Thanks.
Spec URL: http://roma.fedorapeople.org/specs/mingw32-tk.spec SRPM URL: http://roma.fedorapeople.org/srpms/mingw32-tk-8.5.9-1.fc14.src.rpm Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2675829 Rpmlint output: [cascavel:~/RPMS144/lcgrpms] rpmlint mingw32-tk-8.5.9-1.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Thanks.
Builds fine; just one rpmlint complaint: mingw32-tk.src:81: W: macro-in-comment %{name1} which doesn't seem to be a problem to me. There are no comments in a spec file, so macros are still expanded and if they have multiple lines the behavior isn't what you expect. Everything else looks fine. * source files match upstream. sha256sum: f46b33d41e71ef533140f1814961f0dc22d62aac316df4a4fd3357e1fd788b83 tk8.5.9-src.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package. * version packaged is the same as the native Fedora version. * package is noarch. * BuildRequires are proper. * compiler flags are appropriate. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * special mingw32 dependency generators are used. * final provides and requires are sane: mingw32(tk85.dll) mingw32-tk = 8.5.9-1.fc15 = mingw32-filesystem >= 63 mingw32-runtime mingw32(gdi32.dll) mingw32(kernel32.dll) mingw32(msvcrt.dll) mingw32(ole32.dll) mingw32(tcl85.dll) mingw32(tk85.dll) mingw32(user32.dll) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no static libraries. * .dll and .def files in _mingw32_bindir * .dll.a and .la files in _mingw32_libdir * dll files are listed explicitly in %files. * libraries and executables are stripped properly. APPROVED
Thanks, Jason, for finishing this review. New Package SCM Request ======================= Package Name: mingw32-tk Short Description: MinGW Windows graphical toolkit for the Tcl scripting language Owners: roma Branches: f13 f14 el6 InitialCC:roma
Git done (by process-git-requests).