Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 530177

Summary: cobbler post_install_network_config scriptlet overwrites changes made in network-scripts directory.
Product: Red Hat Satellite 5 Reporter: Albert Hopkins <ahopkins>
Component: ProvisioningAssignee: Justin Sherrill <jsherril>
Status: CLOSED ERRATA QA Contact: Garik Khachikyan <gkhachik>
Severity: medium Docs Contact:
Priority: medium    
Version: 530CC: cperry, dmair, gkhachik, mkoci, tao
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-02-16 08:40:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 518256    

Description Albert Hopkins 2009-10-21 19:37:27 UTC
post_install_network_config scriptlet is put in the kickstart's %post section.  This scriptlet removes the client computer's network-scripts directory and thereby any custom configuration done in the kickstart.

I am unsure of a workaround/fix for this issue.

Comment 1 Justin Sherrill 2009-10-21 20:03:55 UTC
So a couple of workarounds: 

A) use a raw-style kickstart.  (Create one on the kickstart upload page).
   This can be created from scratch or you can copy and paste an existing template for a kickstart (found in /var/lib/rhn/kickstarts/wizard).  


B) Change the post_install_network_config snippet in /var/lib/cobbler/snippets.

-Jusitn

Comment 2 Issue Tracker 2009-10-27 11:32:29 UTC
Event posted on 27-10-2009 11:32am GMT by jwrigley

Sadly, our tools meant I overlooked this I-T so I thought I was starting
from scratch with escalating and I talked to mmccune last friday about
this.

I have a reproducer:

Satellite: dhcp-196.gsslab.fab.redhat.com (shell is root/redhat, WebUI is
satadmin/redhat)
Client: dhcp-1-226.fab.redhat.com (also root/redhat)

The kickstart profile in question is jwrigley-test-network-snippet.

We have shown that this only affects reprovisioning.

The reproducer runs like this:

1) Provision the machine with the kickstart profile by booting from CD or
the cobbler bootiso. You'll see on the client that the cobbler.ks has an
empty:
# Start post_install_network_config generated code
# End post_install_network_config generated code

and /etc/sysconfig/network-scripts/ifcfg-bond0 exists.

2) Reprovision from the web interface. This time, all the stuff from
/var/lib/cobbler/snippets/post_install_network_config is included in
/root/cobbler.ks

We pinned this down to the following in the post_install_network_config
script:

#if $getVar("system_name","") != "" ## this is being provisioned by
system records, not profile records

So a bare metal provision uses a cobber profile record, and a reprovision
uses a cobbler system record. The question is, since the satellite
doesn't expose the options that this snippet is supposed to enable (to my
understanding), and the script is effectively not used if using a profile
record, is there any use in having this script at all?

My recommendation to my customer for now is going to be to simply empty
that file, how we manage that with errata releases I'm not sure.


This event sent from IssueTracker by jwrigley 
 issue 355045

Comment 5 Justin Sherrill 2010-01-21 19:51:42 UTC
Here's an idea I would propose.  We move the snippet to be before customer provided %post sections so that the customer can make changes within their %post section and the changes won't be overwritten.

would that be ok for the customer?

Comment 6 Justin Sherrill 2010-01-22 16:14:31 UTC
Spoke to jwrigly and he liked the idea 

Fixed in spacewalk master:  dcc9a0f707631d16982f5df8e0e92c9d5ec03fd7

Comment 9 Garik Khachikyan 2010-02-11 13:32:30 UTC
# VERIFIED

Applied a check against Satellites installed on RHEL4 and RHEL5 servers. The
packages of brew build fixed the issue:
spacewalk-java-0.5.44-66.el[4,5]sat
spacewalk-backend-0.5.28-40.el[4,5]sat

Scenario for verification was: apply a %post script that echo-s some comment in the /etc/sysconfig/network-scripts/ifcfg-eth0

Kickstart of the client system actually does applies the comment and not overwrites with the default values.

Comment 11 errata-xmlrpc 2010-02-16 08:40:08 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2010-0105.html