Spec URL: http://fetter.org/~shackle/ SRPM URL: <srpm info here> Description: A Perl package which helps tokenize SQL.
Oops. SPECT and SRPM, respectively, should be here: http://fetter.org/~shackle/perl-SQL-Tokenizer.spec http://fetter.org/~shackle/SRPMS/perl-SQL-Tokenizer-0.19-1.fc11.src.rpm
Link is not working.
Yes, link still not working. Hangs, firewall?
Sorry. The machine was down for awhile. Here are the updated spec and SRPM. http://fetter.org/~shackle/perl-SQL-Tokenizer.spec http://fetter.org/~shackle/perl-SQL-Tokenizer-0.19-1.fc12.src.rpm
Hi, Looks easy to approve but a couple of comments. I see no reason for including MANIFEST.bak in the resulting package. The license is as perl so not just "Artistic 2.0" see: http://fedoraproject.org/wiki/Packaging/Perl#License_tag
Fixed :) http://fetter.org/~shackle/perl-SQL-Tokenizer.spec http://fetter.org/~shackle/perl-SQL-Tokenizer-0.19-2.fc12.src.rpm
Hi what about the other point namely. %doc Changes MANIFEST.bak README I don't think "MANIFEST.bak" should be included the package. Steve
Fixed :) http://fetter.org/~shackle/perl-SQL-Tokenizer.spec http://fetter.org/~shackle/perl-SQL-Tokenizer-0.19-3.fc12.src.rpm
- rpmlint checks return: OK perl-SQL-Tokenizer.src: E: unknown-key GPG#b73652a5 ^ looks like you've signed your package. This should be ok. - package meets naming guidelines OK - package meets packaging guidelines OK - license (GPL+ or Artistic) OK, text in %doc, matches source - spec file legible, in am. english OK - source matches upstream OK - package compiles on devel (x86) OK http://koji.fedoraproject.org/koji/taskinfo?taskID=2350781 - no missing BR OK - no unnecessary BR NOT OK please remove Test::More from Requires. This is needed only during build. - no locales OK - not relocatable OK - owns all directories that it creates OK - no duplicate files OK - permissions ok OK - %clean ok OK - macro use consistent OK - code, not content OK - no need for -docs OK - nothing in %doc affects runtime OK - no need for .desktop file OK Almost ok ;-)
Updated to 0.20, the current version, removed Test::More from Requires. Newest packages here: http://fetter.org/~shackle/perl-SQL-Tokenizer.spec http://fetter.org/~shackle/perl-SQL-Tokenizer-0.20-1.fc12.src.rpm
SRPM can't be found.
Oops. sorry. Wrong URL. The correct URLs are: http://fetter.org/~shackle/perl-SQL-Tokenizer.spec http://fetter.org/~shackle/perl-SQL-Tokenizer-0.20-1.fc13.src.rpm
- rpmlint checks return: perl-SQL-Tokenizer.src: E: unknown-key GPG#b73652a5 OK - package meets naming guidelines OK - package meets packaging guidelines OK - license (GPL+ or Artistic) OK, text in %doc, matches source - spec file legible, in am. english OK - source matches upstream 0cd63eb036f81e22d1d58fc1f81beb5f OK - package compiles on devel (x86) OK - no missing BR OK - no unnecessary BR OK - no locales OK - not relocatable OK - owns all directories that it creates OK - no duplicate files OK - permissions ok OK - %clean ok OK - macro use consistent OK - code, not content OK - no need for -docs OK - nothing in %doc affects runtime OK - no need for .desktop file OK
Could you comment these two issues: perl-SQL-Tokenizer.src: E: unknown-key GPG#b73652a5 perl-SQL-Tokenizer.noarch: W: hidden-file-or-dir /usr/share/perl5/vendor_perl/SQL/._Tokenizer.pm After resolving these two, it should be ok.
Ping?
What is it you'd like done about them?
perl-SQL-Tokenizer.src: E: unknown-key GPG#b73652a5 ^ I suppose this is false positive. Key is not needed for functionality. perl-SQL-Tokenizer.noarch: W: hidden-file-or-dir /usr/share/perl5/vendor_perl/SQL/._Tokenizer.pm This is installed. Is it needed? If not, could you remove it?
Ping? If you are still interested in this package, could you remove the file ._Tokenizer.pm or comment, why it is needed? We could finish it in that case.
Oops. I'll try to get on this tonight. How do I remove it? Cheers, David.
(In reply to comment #19) > Oops. I'll try to get on this tonight. How do I remove it? > > Cheers, > David. You should remove it in prep part of spec file. rm -rf lib/SQL/._Tokenizer.pm I must ask. Are you already sponsored in Fedora?
Done :) http://fetter.org/~shackle/perl-SQL-Tokenizer.spec http://fetter.org/~shackle/perl-SQL-Tokenizer-0.20-2.fc14.src.rpm Re: sponsorship, not that I know of. What's involved?
You've started a lot of reviews as I can see in bugzilla, but you've never finished any. Why? You need to find someone, who will be your sponsor, which means give you access to Fedora account system. I've added sponsorship request as blocker. For details about sponsorship see: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group In one of previous reviews you lost possible sponsor, so I'm not sure how successful you'll be this time. (I'm not sponsor).
Hi, I'm sponsor and I can sponsor you. Are you still interrested in finishing this package review?
Please response ASAP or this bug may be closed. If you don't have interests now, no problem and please close this.