Bug 531423 - double-spacing in language and keyboard dialogs
Summary: double-spacing in language and keyboard dialogs
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: gdm
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: jmccann
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F12Target
TreeView+ depends on / blocked
 
Reported: 2009-10-28 08:53 UTC by Jens Petersen
Modified: 2015-01-14 23:23 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-11-03 02:17:21 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
language dialog (311.75 KB, image/png)
2009-10-28 08:56 UTC, Jens Petersen
no flags Details
kbd dialog shot (328.56 KB, image/png)
2009-10-28 08:56 UTC, Jens Petersen
no flags Details

Description Jens Petersen 2009-10-28 08:53:50 UTC
Description of problem:
GDM's language and keyboard menus are now double-spaced apparently.

Version-Release number of selected component (if applicable):

Steps to Reproduce:
1. boot live or latest rawhide
  
Actual results:
see screenshots

Expected results:
no big gaps in the lists

Additional info:
I added this to F12Blocker - maybe a little harsh
but I feel this would be very good to fix for f12-final.

Comment 1 Jens Petersen 2009-10-28 08:56:10 UTC
Created attachment 366401 [details]
language dialog

Comment 2 Jens Petersen 2009-10-28 08:56:53 UTC
Created attachment 366402 [details]
kbd dialog shot

Comment 3 A S Alam 2009-10-28 09:51:05 UTC
produced with 
gdm-2.28.1-5.fc12

Comment 4 Jens Petersen 2009-10-28 09:52:18 UTC
Reverting to gdm-2.28.0-9.fc12 in F12-Beta fixes the problem.

Comment 5 Jens Petersen 2009-10-28 09:53:09 UTC
(Also still happens with gdm-2.28.1-12.fc12.)

Comment 6 Ray Strode [halfline] 2009-10-28 14:10:52 UTC
This is probably an artifact of:

http://git.gnome.org/cgit/gdm/commit/?id=2b49177235ef243056c30533bd8eec32cfb86b63

Comment 7 Jens Petersen 2009-10-29 05:44:25 UTC
+                *height = cell->ypad * 2 + 42;

So is 42 too big or ?

Comment 8 Matthias Clasen 2009-10-29 11:33:42 UTC
Well, thats the cell renderer just for the timer in the user list. I don't _think_ that should affect the language / keyboard lists.

Comment 9 Ray Strode [halfline] 2009-10-29 14:01:09 UTC
i fixed this last night.

Comment 10 Adam Williamson 2009-10-29 16:58:05 UTC
Fixed build is 2.28.1-16:

http://koji.fedoraproject.org/koji/buildinfo?buildID=138811

I don't see a tag request filed yet.

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 11 Adam Williamson 2009-10-30 17:35:18 UTC
This was discussed at the blocker meeting today. We decided this is not a blocker issue, so downgrading to target. You can still request a tag for final, it's up to releng whether to accept it.

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 12 Jens Petersen 2009-11-03 01:10:08 UTC
Works well for me - could you please request for f12-final?

Comment 13 Ray Strode [halfline] 2009-11-03 02:17:21 UTC
already tagged.


Note You need to log in before you can comment on or make changes to this bug.