Spec URL: http://dgoodwin.fedorapeople.org/rho/rho.spec SRPM URL: http://dgoodwin.fedorapeople.org/rho/rho-0.0.6-1.fc11.src.rpm Description: Rho is a tool for scanning your network, logging into systems via SSH, and retrieving information about them.
- You are missing the Source URL. Fix it. - Replace gzip rho.1 mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1/ mv rho.1.gz $RPM_BUILD_ROOT%{_mandir}/man1/ with install -D -p -m 644 gzip.1 $RPM_BUILD_ROOT%{_mandir}/man1/rho.1 (If you move the file, short circuiting the build won't work. Also, rpm handles compression of man files by itself, so you don't need to do it manually.)
alikins will be taking over this package, if possible (when package is added) it'd be great if he could be added as the owner. If not we'll just dole out the permissions ourselves. Fixes for the above coming soon.
new version of packages is at: spec: http://alikins.fedorapeople.org/files/rho/rho.spec src rpm: http://alikins.fedorapeople.org/files/rho/rho-0.0.10-1.fc11.src.rpm Includes fixes for comment #1.
version 0.0.12 avaiable at http://alikins.fedorapeople.org/files/rho/
version 0.0.15 available now at http://alikins.fedorapeople.org/files/rho/
version 0.0.16 available now at http://alikins.fedorapeople.org/files/rho/
in the future please paste links to the spec and srpm
This looks mostly fine to me, with the exception that python packages must now package eggs if they're built: https://fedoraproject.org/wiki/Packaging/Python/Eggs Also, you can drop the -O1 arg to 'setup.py install', the .pyo files are automatically generated Attaching a patch to fix those and a couple of other trivial things Other things checked: - rpmlint passes with no warnings/errors - adheres to python packaging guidelines - basic package meta-data is correct - source url is correct - both BuildRequires are actually required - can't see any missing BuildRequires - ditto for Requires - all requires are available in Fedora - build procedure is correct - .pyc and .pyo files are packaged, as per guidelines - all dirs are packaged - %changelog format is correct - etc. etc. I'd be happy to give this a fedora-review+
Created attachment 369392 [details] misc fixes
Patch applied and new versions built: http://alikins.fedorapeople.org/files/rho/rho.spec http://alikins.fedorapeople.org/files/rho/rho-0.0.17-1.fc11.src.rpm
sha256sum rho-0.0.17.tar.gz fedora/SOURCES/rho-0.0.17.tar.gz 7e0c0aebcf712f6960cb865ce766a329bda5b425e5b1e76ba553645e864282d4 rho-0.0.17.tar.gz 7e0c0aebcf712f6960cb865ce766a329bda5b425e5b1e76ba553645e864282d4 fedora/SOURCES/rho-0.0.17.tar.gz upstream source matches packaging meets guidelines Approved
New Package CVS Request ======================= Package Name: rho Short Description: An SSH system profiler. Owners: alikins jmrodri dgoodwin Branches: F-11 F-12 EL-5 InitialCC: alikins jmrodri dgoodwin
CVS done.
This package is in Fedora for very long time. See http://koji.fedoraproject.org/koji/packageinfo?packageID=9514 . Closing.