Bug 531940 - Inconsistent use of xml vs. xmlOutput in HTTP request argument
Summary: Inconsistent use of xml vs. xmlOutput in HTTP request argument
Status: MODIFIED
Alias: None
Product: Dogtag Certificate System
Classification: Retired
Component: Certificate Manager
Version: 1.2
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: John Dennis
QA Contact: Ben Levenson
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: ipa-fixes freeipa20
TreeView+ depends on / blocked
 
Reported: 2009-10-29 22:15 UTC by John Dennis
Modified: 2015-01-05 00:16 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed:


Attachments (Terms of Use)
patch (837 bytes, patch)
2009-11-12 15:01 UTC, John Dennis
no flags Details | Diff

Description John Dennis 2009-10-29 22:15:42 UTC
All the scriplets accept a HTTP request argument indicating if XML output is desired instead of HTML. However the argument usage is inconsistent. In all cases except /ca/ee/ca/profileSubmit the argument is "xml" but for /ca/ee/ca/profileSubmit the argument is "xmlOutput".

All scriplets should use the same flag for the same functionality.

pki/base/common/src/com/netscape/cms/servlet/profile/ProfileSubmitServlet.java

should be modified to also accept "xml", this would allow consistent argument usage across all scriplets but preserve backwards compatibility.

Comment 1 John Dennis 2009-11-12 15:01:18 UTC
Created attachment 369228 [details]
patch

Comment 2 Andrew Wnuk 2009-11-17 23:11:36 UTC
attachment (id=369228) +awnuk

Comment 3 Andrew Wnuk 2009-11-25 23:42:10 UTC
Patch included in in bug #533979 and attachment #373874 [details] is committed.


Note You need to log in before you can comment on or make changes to this bug.