Bug 531987 - Review Request: wtop - top for webserver
Summary: Review Request: wtop - top for webserver
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-30 06:18 UTC by kushaldas@gmail.com
Modified: 2009-11-27 21:44 UTC (History)
6 users (show)

Fixed In Version: 0.6.1-2.fc12
Clone Of:
Environment:
Last Closed: 2009-11-27 21:44:00 UTC
Type: ---
Embargoed:
panemade: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description kushaldas@gmail.com 2009-10-30 06:18:16 UTC
Spec URL: http://kushal.fedorapeople.org/wtop.spec
SRPM URL: http://kushal.fedorapeople.org/wtop-0.6.1-1.fc11.src.rpm
Description: Wtop like "top" for your webserver.

Comment 1 kushaldas@gmail.com 2009-11-02 06:47:13 UTC
Koji scratch build link http://koji.fedoraproject.org/koji/taskinfo?taskID=1781942

Comment 2 Parag AN(पराग) 2009-11-05 04:58:22 UTC
after I installed this on F-11, I am getting
IOError: [Errno 2] No such file or directory: '/var/log/apache2/access_log'

Comment 3 kushaldas@gmail.com 2009-11-05 05:18:24 UTC
You have to edit the configuration file properly , details can be found http://code.google.com/p/wtop/wiki/Installing

Also it requires a bit high traffic to show any output.

Comment 4 Parag AN(पराग) 2009-11-05 06:18:58 UTC

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1781942
+ rpmlint output for SRPM and for RPM.
wtop.src: W: no-buildroot-tag
==> Ok to ignore
+ source files match upstream url(sha1sum)
9f715744779b997935840a2cf97211533a446aca  wtop-0.6.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Suggestions
you can change that path in spec in %prep as
sed -i -e "s|/var/log/apache2/|/var/log/httpd/|" wtop.cfg
APPROVED.


APPROVED.

Comment 5 kushaldas@gmail.com 2009-11-19 08:57:47 UTC
New Package CVS Request
=======================
Package Name: wtop
Short Description: top for webserver
Owners: kushal
Branches: F-12
InitialCC: kushal

Comment 6 Itamar Reis Peixoto 2009-11-19 17:09:29 UTC
why not EL-5 and F-11 too ?

Comment 7 Jason Tibbitts 2009-11-20 01:20:48 UTC
CVS done.

Comment 8 kushaldas@gmail.com 2009-11-20 05:00:25 UTC
(In reply to comment #6)
> why not EL-5 and F-11 too ?  

If you want them there, please co-maintain the branches :)

Comment 9 Fedora Update System 2009-11-27 11:05:14 UTC
lekhonee-gnome-0.8-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/lekhonee-gnome-0.8-2.fc12

Comment 10 Fedora Update System 2009-11-27 11:42:00 UTC
wtop-0.6.1-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/wtop-0.6.1-2.fc12

Comment 11 Fedora Update System 2009-11-27 21:43:55 UTC
wtop-0.6.1-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.