Bug 532315 - Review Request: nanoxml - Small XML parser for Java
Summary: Review Request: nanoxml - Small XML parser for Java
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lubomir Rintel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: F13FeatureIDEA
Keywords:
: 532529 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-11-01 14:37 UTC by Michal Ingeli
Modified: 2009-11-27 21:53 UTC (History)
4 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2009-11-27 21:53:07 UTC
lkundrak: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Michal Ingeli 2009-11-01 14:37:28 UTC
Spec URL: http://v3.sk/~xyzz/rpm/intellij-idea/nanoxml.spec
SRPM URL: http://v3.sk/~xyzz/rpm/intellij-idea/nanoxml-2.2.3-4.fc11.src.rpm

Description:
The intent of NanoXML is to be a small parser which is easy to use. Although many features were added to NanoXML, it is very small. The full parser with builder fits in a JAR file of about 32K.

Comment 1 Lubomir Rintel 2009-11-01 15:07:57 UTC
1.) Please remove jpackage artifacts:

section macro:
%define section free

javadoc symlink (you even create it twice for some reason!?):
ln -s %{name}-%{version} $RPM_BUILD_ROOT%{_javadocdir}/%{name} # ghost symlink

2.) You can probably rely on default file modes:

-%defattr(0644,root,root,0755)
+%defattr(-,root,root,-)

3.) Please do not include TeX sources in documentation. PDFs ale probably enough.

4.) Please consider renaming nanoxml-manual-lite to nanoxml-lite-manual, which may be more consistent. If you need to retain compatibility and upgrade path from jpackage, use  Provides tag and Obsoletes tag for older version to properly replace it.

Comment 2 Michal Ingeli 2009-11-02 11:23:18 UTC
(In reply to comment #1)
> 1.) Please remove jpackage artifacts:
> 
> section macro:
> %define section free

done

> javadoc symlink (you even create it twice for some reason!?):
> ln -s %{name}-%{version} $RPM_BUILD_ROOT%{_javadocdir}/%{name} # ghost symlink

another forgotten fragment of original package

> 2.) You can probably rely on default file modes:
> 
> -%defattr(0644,root,root,0755)
> +%defattr(-,root,root,-)
>
> > 3.) Please do not include TeX sources in documentation. PDFs ale probably
> enough.

done. some files had +x in documentation sources, but as they are not included now in -manual subpacakges, I can rely on defaults.

> 4.) Please consider renaming nanoxml-manual-lite to nanoxml-lite-manual, which
> may be more consistent. If you need to retain compatibility and upgrade path
> from jpackage, use  Provides tag and Obsoletes tag for older version to
> properly replace it.  

Renamed. I also added obsoletes and provides with version ranges. Hope I did it right way.

Spec URL: http://v3.sk/~xyzz/rpm/intellij-idea/nanoxml.spec
SRPM URL: http://v3.sk/~xyzz/rpm/intellij-idea/nanoxml-2.2.3-5.fc11.src.rpm

Comment 3 Jason Tibbitts 2009-11-02 20:47:08 UTC
*** Bug 532529 has been marked as a duplicate of this bug. ***

Comment 4 Jason Tibbitts 2009-11-02 21:16:08 UTC
It looks like the fedora-cvs flag has been mistakenly set, instead of the fedora-review flag.

Comment 5 Lubomir Rintel 2009-11-02 21:59:13 UTC
(In reply to comment #4)
> It looks like the fedora-cvs flag has been mistakenly set, instead of the
> fedora-review flag.  

Yup, I meant to set the review flag.

The package looks fine now.

APPROVED

Comment 6 Michal Ingeli 2009-11-03 11:04:02 UTC
New Package CVS Request
=======================
Package Name: nanoxml
Short Description: Small XML parser for Java
Owners: ksyz
Branches: F-11 F-12 
InitialCC:

Comment 7 Kevin Fenzi 2009-11-03 19:11:54 UTC
cvs done.

Comment 8 Michal Ingeli 2009-11-04 10:59:03 UTC
thanks for review and cvs

Comment 9 Fedora Update System 2009-11-09 11:26:14 UTC
nanoxml-2.2.3-6.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/nanoxml-2.2.3-6.fc12

Comment 10 Fedora Update System 2009-11-10 17:42:39 UTC
nanoxml-2.2.3-6.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update nanoxml'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-11161

Comment 11 Fedora Update System 2009-11-27 21:53:01 UTC
nanoxml-2.2.3-6.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.