Spec URL: http://jcollie.fedorapeople.org/asterisk-sounds-extra.spec SRPM URL: http://jcollie.fedorapeople.org/asterisk-sounds-extra-1.4.9-1.fc12.src.rpm Description: Extra sounds for Asterisk
Updated to the latest release: Spec URL: http://jcollie.fedorapeople.org/asterisk-sounds-extra.spec SRPM URL: http://jcollie.fedorapeople.org/asterisk-sounds-extra-1.4.11-1.fc13.src.rpm
This is, like, the easiest review ever. Plus it includes hilarious phrases. I've no idea why it's sat here without comment for a whole year now. Since it appears that asterisk only targets modern Fedora and EPEL6, you can remove BuildRoot:, %clean and the first line of %install if you like. I can't seem to figure out where you find a license statement. In the asterisk documentation I see only that the code is GPL and the that hold music is non-free. I saw some mailing list posts about the core sound tarballs supposedly including a license statement, but I don't see anything in the extra sound tarballs. Nothing seems to own /usr/share/asterisk/sounds/fr. Did you mean to have a dependency on asterisk-sounds-core-fr somewhere? * source files match upstream. sha256sum: ab9e91747f9ad424b14e8f5508018eeaf06a854e4f5b1234b60a712f7ba451bd asterisk-extra-sounds-en-alaw-1.4.11.tar.gz cc302da7156a134e1c11bd960e4aef088ee403b443e67aaa10c780e3d75957ed asterisk-extra-sounds-en-g722-1.4.11.tar.gz e8589bf4f88c6ba75315be8c55f2bfde7086b62050d5815f4b41cb43b8e1fbb0 asterisk-extra-sounds-en-g729-1.4.11.tar.gz d5f031cc31ebebec99ce3fcf44ff947bd7b27b5e9565a7b3a6185c2d1bda094c asterisk-extra-sounds-en-gsm-1.4.11.tar.gz cd62cc292ce506d7ce1acf37caed07c986eb96eb795073deae289cbf0fe324fc asterisk-extra-sounds-en-siren14-1.4.11.tar.gz 2af1ebba33566f47593eb0ccdc99d6a20865c6338ffa81e1fae1c2237c28d576 asterisk-extra-sounds-en-siren7-1.4.11.tar.gz 5d3836e512cfcb06feff7f6e64229a5f7ca5d4186b21c079a7b998109c242d68 asterisk-extra-sounds-en-sln16-1.4.11.tar.gz 22dd692dde962683601599926efa9281624fce469776bccbd6f5c6b727e77a4a asterisk-extra-sounds-en-ulaw-1.4.11.tar.gz 34cefb8aa31021e947c77033b99ced9d62f9d8785b45a04bd12675a0eddd9ed5 asterisk-extra-sounds-en-wav-1.4.11.tar.gz 2f042b94474000d15d373c727c9ad9dd4151ce6100b7cc7486748babc3879836 asterisk-extra-sounds-fr-alaw-1.4.11.tar.gz 0bc0f9fe98d528625db827d474cd619f79abbb9d1495936e41f86b69d63f3f2d asterisk-extra-sounds-fr-g722-1.4.11.tar.gz 687b6e2f7632372a125acb97ead9b597819ec02c4b77cd6e62fd070b34fd9b26 asterisk-extra-sounds-fr-g729-1.4.11.tar.gz 1608776dbad3a97aad525eb4087d5c9944d7856ff8e015afeb353c5e97b38746 asterisk-extra-sounds-fr-gsm-1.4.11.tar.gz bcf7b3528c2e8a37badd9d5fa4aeac6357bd113974288345ca9e56fcdb1080e3 asterisk-extra-sounds-fr-siren14-1.4.11.tar.gz a02d8d554ec365dd32a747845457323e649928dce1ac0cfffd6910b622130981 asterisk-extra-sounds-fr-siren7-1.4.11.tar.gz d130ca16550dbc85ccba3ce791a4b1aadbde6e88b84579cc0446af3e6e4870a6 asterisk-extra-sounds-fr-sln16-1.4.11.tar.gz 7a20535f45ed4415e7adf6f2e19dcb6419bee8262ac11611778ed8e6eabbf0cf asterisk-extra-sounds-fr-ulaw-1.4.11.tar.gz d3891730151e0a76c0a811499040379535d3ab7b63ee10f3a2e12b5c083887c0 asterisk-extra-sounds-fr-wav-1.4.11.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summaries are OK. * descriptions are OK. * dist tag is present. ? can't tell what the actual license is.license. * latest version is being packaged. * BuildRequires are proper (none) * package builds in mock (f14, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: asterisk-sounds-extra-en-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra-en = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-en-alaw-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-en-alaw = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-en = 1.4.11-1.fc14 asterisk-sounds-extra-en-g722-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-en-g722 = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-en = 1.4.11-1.fc14 asterisk-sounds-extra-en-g729-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-en-g729 = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-en = 1.4.11-1.fc14 asterisk-sounds-extra-en-gsm-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-en-gsm = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-en = 1.4.11-1.fc14 asterisk-sounds-extra-en-siren14-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-en-siren14 = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-en = 1.4.11-1.fc14 asterisk-sounds-extra-en-siren7-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-en-siren7 = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-en = 1.4.11-1.fc14 asterisk-sounds-extra-en-sln16-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-en-sln16 = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-en = 1.4.11-1.fc14 asterisk-sounds-extra-en-ulaw-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-en-ulaw = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-en = 1.4.11-1.fc14 asterisk-sounds-extra-en-wav-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-en-wav = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-en = 1.4.11-1.fc14 asterisk-sounds-extra-fr-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra-fr = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-fr-alaw-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-fr-alaw = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-fr = 1.4.11-1.fc14 asterisk-sounds-extra-fr-g722-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-fr-g722 = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-fr = 1.4.11-1.fc14 asterisk-sounds-extra-fr-g729-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-fr-g729 = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-fr = 1.4.11-1.fc14 asterisk-sounds-extra-fr-gsm-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-fr-gsm = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-fr = 1.4.11-1.fc14 asterisk-sounds-extra-fr-siren14-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-fr-siren14 = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-fr = 1.4.11-1.fc14 asterisk-sounds-extra-fr-siren7-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-fr-siren7 = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-fr = 1.4.11-1.fc14 asterisk-sounds-extra-fr-sln16-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-fr-sln16 = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-fr = 1.4.11-1.fc14 asterisk-sounds-extra-fr-ulaw-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-fr-ulaw = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-fr = 1.4.11-1.fc14 asterisk-sounds-extra-fr-wav-1.4.11-1.fc14.noarch.rpm asterisk-sounds-extra = 1.4.11-1.fc14 asterisk-sounds-extra-fr-wav = 1.4.11-1.fc14 = asterisk >= 1.4.0 asterisk-sounds-extra-fr = 1.4.11-1.fc14 X /usr/share/asterisk/sounds/fr is unowned. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * acceptable content.
(In reply to comment #2) > > Since it appears that asterisk only targets modern Fedora and EPEL6, you can > remove BuildRoot:, %clean and the first line of %install if you like. Removed. > I can't seem to figure out where you find a license statement. In the asterisk > documentation I see only that the code is GPL and the that hold music is > non-free. I saw some mailing list posts about the core sound tarballs > supposedly including a license statement, but I don't see anything in the extra > sound tarballs. Hmm looking this over all I could find was: https://issues.asterisk.org/view.php?id=10144 I'll submit a bug to Digium asking for clarification. > Nothing seems to own /usr/share/asterisk/sounds/fr. Did you mean to have a > dependency on asterisk-sounds-core-fr somewhere? Added dependency in new spec: http://jcollie.fedorapeople.org/asterisk-sounds-extra.spec
Any news on this?
17 months after my review and 13 months after the last ping, I think it's time this was closed out.