Bug 532701 - dprintk macro in NFS code doesn't work in some files
Summary: dprintk macro in NFS code doesn't work in some files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.4
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Jeff Layton
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks: 526950
TreeView+ depends on / blocked
 
Reported: 2009-11-03 15:35 UTC by Jeff Layton
Modified: 2010-03-30 07:43 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-30 07:43:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
move NFS_DEBUG definition (1.57 KB, patch)
2009-11-03 15:35 UTC, Jeff Layton
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2010:0178 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.5 kernel security and bug fix update 2010-03-29 12:18:21 UTC

Description Jeff Layton 2009-11-03 15:35:23 UTC
Created attachment 367312 [details]
move NFS_DEBUG definition

While troubleshooting a problem in another case, I found that the dprintk macro wasn't working in some places. Not a critical problem but potentially confusing if/when we were to ask someone for nfs_debug info.

This upstream patch fixes it and I think we should consider taking it for 5.5.

Comment 1 Jeff Layton 2009-11-03 15:37:05 UTC
For instance, none of the dprintk's in fs/nfs/file.c actually work as it stands now. Again, not a critical issue, but something we should probably fix to make future debugging more robust.

Testing this should be easy:

Turn on nfs_debugging, do some operations and see if any of the dprintk's in file.c end up in dmesg.

Comment 3 RHEL Program Management 2009-11-10 19:21:07 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 4 Don Zickus 2009-12-02 21:15:08 UTC
in kernel-2.6.18-176.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Please do NOT transition this bugzilla state to VERIFIED until our QE team
has sent specific instructions indicating when to do so.  However feel free
to provide a comment indicating that this fix has been verified.

Comment 8 errata-xmlrpc 2010-03-30 07:43:33 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html


Note You need to log in before you can comment on or make changes to this bug.