Spec URL: http://dev.laptop.org/~dsd/20091104/libertas-sd8686-firmware.spec SRPM URL: http://dev.laptop.org/~dsd/20091104/libertas-sd8686-firmware-9.70.7.p0-1.fc11.src.rpm Description: This is the firmware used by the in-mainline kernel libertas_sdio driver. It is needed for the OLPC XO-1.5 The package is based on the existing libertas-usb8388-firmware package with only the minimal changes needed. So hopefully this is a simple review :)
I'll review it.
Few notes: * I advice you to add the following line to the %prep section (to avoid copying firmware blobs directly into ~/rpmbuild/BUILD directory): %setup -c -T * Also, I advice you to fix line ending in LICENSE file in %prep section instead of fixing it in the %install section. * The file, with license, must not be placed in /lib/firmware. You must mark it as %doc instead. * Since you're using /lib/firmware/ then you should add "Requires: udev" (the owner of this directory). See rpm -qf /lib/firmware * No need to explicitly create "$RPM_BUILD_ROOT/lib/firmware" in your case. Just add -D switch to install command. * You're using %{__install} macro instead of plain "install". Why? I don't see any reasons to do so. This is not a blocker, actually - I just want to know :). Other things looks sane for me.
Thanks for reviewing! %{__install} is being used as this spec file is a copy of libertas-usb8388-firmware.spec with only a couple of small changes to make it for sd8686 instead. The macro is being used there. (incidentally, all of your feedback applies there too) Fixed version at http://dev.laptop.org/~dsd/20091105/libertas-sd8686-firmware.spec http://dev.laptop.org/~dsd/20091105/libertas-sd8686-firmware-9.70.7.p0-1.fc11.src.rpm
One new issue - do NOT move SOURCE4, or your next build attempt will be failed. Just "cp -p" it as other sources. Ok, assuming, that you'll fixed it (easyfix, actually), here is my REVIEW: + rpmlint is silent [petro@Sulaco SPECS]$ rpmlint ../RPMS/noarch/libertas-sd8686-firmware-9.70.7.p0-1.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [petro@Sulaco SPECS]$ + The package ШЫ named according to the Package Naming Guidelines . + The spec file name matchУЫ the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines . + The package is licensed with a Fedora approved license and meets the Licensing Guidelines . + The License field in the package spec file matches the actual license. + The file, containing the text of the license(s) for the package, is included in %doc.[4] + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. [petro@Sulaco SOURCES]$ sha256sum LICENSE* sd8686* 8baf6df7462fdb1a9710e94d230d11b2fd1901be34f9388ab0ad5efd2fa32898 LICENSE 8baf6df7462fdb1a9710e94d230d11b2fd1901be34f9388ab0ad5efd2fa32898 LICENSE.1 ffa1e1fc047772eccc27e9c1df8293545051fa45a5273a89554115c69df83e39 sd8686-9.70.7.p0.bin ffa1e1fc047772eccc27e9c1df8293545051fa45a5273a89554115c69df83e39 sd8686-9.70.7.p0.bin.1 c1d9fadcdda1e14544d9e6e3560464a3e16aca276592351d5768cb569a4122ea sd8686-9.70.7.p0.bin.md5 c1d9fadcdda1e14544d9e6e3560464a3e16aca276592351d5768cb569a4122ea sd8686-9.70.7.p0.bin.md5.1 b0157d1f4518e806c0bc5128ab302a7f97d78ee34b84cb41cb4f2bbbb2a00e6d sd8686_helper.bin b0157d1f4518e806c0bc5128ab302a7f97d78ee34b84cb41cb4f2bbbb2a00e6d sd8686_helper.bin.1 bb1ed4e85a8ffa94339f0547f2234d75cb7925bbf333cba6a08b42401ff2559e sd8686_helper.bin.md5 bb1ed4e85a8ffa94339f0547f2234d75cb7925bbf333cba6a08b42401ff2559e sd8686_helper.bin.md5.1 [petro@Sulaco SOURCES]$ + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. Please, adjust your spec to not mv LICENSE, and I'll finish the review.
Thanks fixed versions http://dev.laptop.org/~dsd/20091105/try2/libertas-sd8686-firmware.spec http://dev.laptop.org/~dsd/20091105/try2/libertas-sd8686-firmware-9.70.7.p0-1.fc11.src.rpm
Ok, good. This package is APPROVED
New Package CVS Request ======================= Package Name: libertas-sd8686-firmware Short Description: Firmware for Marvell Libertas SD 8686 Network Adapter Owners: dsd cjb pbrobinson Branches: F-11 F-12 InitialCC:
cvs done.
Ping, Daniel. We're all waiting for you :)
Sorry, mistyped this bug number in the update submission and forgot to close it manually. This package is now in F11 and F12 updates-testing. Thanks for your help!