Spec URL: http://chkr.fedorapeople.org/review/xskat.spec SRPM URL: http://chkr.fedorapeople.org/review/xskat-4.0.0-1.src.rpm Description: XSkat lets you play the card game Skat as defined by the official Skat Order. Features: * Single- and multiplayer mode * Playing over LAN or IRC * Game lists and logs * Three types of scoring * English or German text * German or French suited cards * Selectable computer playing strength * Pre-definable card distributions * Variations: Ramsch, Bock, Kontra & Re, ... Please note that rpmlint's complaint about the license is a false positive - the license was recently reviewed on the fedora-legal-list and added to the acceptable licenses of Fedora: https://fedoraproject.org/wiki/Licensing/XSkat_License
This programm does not start: $ xskat Font 10x20 not found
It looks like that xksat requires explicitly an 10x20 font. I've not seen this issue before since I had this font already installed. I've added a Requires: tag for the package which contains this font. Spec URL: http://chkr.fedorapeople.org/review/xskat.spec SRPM URL: http://chkr.fedorapeople.org/review/xskat-4.0.0-2.src.rpm
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: [] devel/i386 [] devel/x86_64 [] F11/i386 [x] F11/x86_64 [x] Rpmlint output: $ rpmlint xskat.spec xskat-4.0.0-2.src.rpm x86_64/xskat-* xskat.src: W: invalid-license XSkat xskat.x86_64: W: invalid-license XSkat xskat-debuginfo.x86_64: W: invalid-license XSkat 3 packages and 1 specfiles checked; 0 errors, 3 warnings. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: XSkat [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. Upstream source: 6744cea48a890771736b75083e7ea2b5 Build source: 6744cea48a890771736b75083e7ea2b5 [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [?] Permissions on files are set properly. I'm unsure if: -rw-r--r-- /usr/share/doc/xskat-4.0.0/README.IRC -rw-r--r-- /usr/share/doc/xskat-4.0.0/README.IRC-de -r--r--r-- /usr/share/man/de/man6/xskat.6.gz -r--r--r-- /usr/share/man/man6/xskat.6.gz -rw-r--r-- /usr/share/pixmaps/xskat.xpm is completely correct. It's unusual to use -r--r--r--, but it works, so, ok. [x] Package has a %clean section, which contains rm -rf %{buildroot}. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [x] Package contains a properly installed %{name}.desktop file if it is a GUI application. [!] Package does not own files or directories owned by other packages. in %files: %{_datadir}/applications is wrong, should be %{_datadir}/applications/* === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [x] Package should compile and build into binary rpms on all supported architectures. http://koji.fedoraproject.org/koji/taskinfo?taskID=1791883 [x] Package functions as described (no hardware to test with). [x] Scriptlets must be sane, if used. Issues: - in %files: %{_datadir}/applications is wrong, should be %{_datadir}/applications/* - a comment about the permissions would be good ;)
Forgot to add use %global and not %define: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
(In reply to comment #3) Thank you very much for the detailed review. > Issues: > - in %files: %{_datadir}/applications is wrong, > should be %{_datadir}/applications/* > - a comment about the permissions would be good ;) (In reply to comment #4) > Forgot to add use %global and not %define: All mentioned issues are fixed in the new package: %changelog * Fri Nov 06 2009 Christian Krause <chkr> - 4.0.0-3 - Don't own /usr/share/applications - Fix permissions of man pages - Use %%global instead of %%define Spec URL: http://chkr.fedorapeople.org/review/xskat.spec SRPM URL: http://chkr.fedorapeople.org/review/xskat-4.0.0-3.src.rpm
APPROVED
New Package CVS Request ======================= Package Name: xskat Short Description: The card game Skat Owners: chkr Branches: F-11 F-12
cvs done.
xskat-4.0.0-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/xskat-4.0.0-4.fc12
xskat-4.0.0-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/xskat-4.0.0-4.fc11
xskat-4.0.0-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
xskat-4.0.0-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.