Bug 533164 - Duplicate message keys in StringResource_*.xml files
Summary: Duplicate message keys in StringResource_*.xml files
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite 5
Classification: Red Hat
Component: i18n
Version: 530
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Stephen Herr
QA Contact: Martin Korbel
URL:
Whiteboard:
Depends On:
Blocks: sat550-lowbug
TreeView+ depends on / blocked
 
Reported: 2009-11-05 12:52 UTC by Jan Pazdziora
Modified: 2012-09-21 09:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-09-21 09:35:08 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Jan Pazdziora 2009-11-05 12:52:11 UTC
Description of problem:

While investigating bug 532936, I found out that we have at least one more duplicate message in our StringResource files, ssmchildsubs.jsp.unsubscribe. We should make sure that there are not duplicates. Ideally, build of rhn-java-sat should just fail if any duplicates are found.

Version-Release number of selected component (if applicable):

Satellite 5.3.0.

How reproducible:

Deterministic, looking to sources.

Steps to Reproduce:
1. $ grep ssmchildsubs.jsp.unsubscribe java/code/src/com/redhat/rhn/frontend/strings/jsp/StringResource_de.xml
2. $ find java -name 'StringResource_*.xml' | \
     while read i ; \
       do echo $i ; \
       xpath '*//trans-unit/@id' 2>&1 < $i | sort | uniq -d ; \
     done
  
Actual results:

			<trans-unit id="ssmchildsubs.jsp.unsubscribe">
			<trans-unit id="ssmchildsubs.jsp.unsubscribe">

java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_es.xml
 id="sdc.config.diff.files_2_dirs_1"-- NODE --
 id="sdc.config.diff.files_2_dirs_2"-- NODE --
java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_ru.xml
 id="sdc.config.diff.files_2_dirs_1"-- NODE --
 id="sdc.config.diff.files_2_dirs_2"-- NODE --
java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_hi.xml
 id="sdc.config.diff.files_2_dirs_1"-- NODE --
 id="sdc.config.diff.files_2_dirs_2"-- NODE --
java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_ta.xml
 id="sdc.config.diff.files_2_dirs_1"-- NODE --
 id="sdc.config.diff.files_2_dirs_2"-- NODE --
java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_pa.xml
 id="sdc.config.diff.files_2_dirs_1"-- NODE --
 id="sdc.config.diff.files_2_dirs_2"-- NODE --
java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_zh_CN.xml
 id="sdc.config.diff.files_2_dirs_1"-- NODE --
 id="sdc.config.diff.files_2_dirs_2"-- NODE --
java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_de.xml
 id="sdc.config.diff.files_2_dirs_1"-- NODE --
 id="sdc.config.diff.files_2_dirs_2"-- NODE --
java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_it.xml
 id="sdc.config.diff.files_2_dirs_1"-- NODE --
 id="sdc.config.diff.files_2_dirs_2"-- NODE --
java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_en_US.xml
java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_fr.xml
 id="sdc.config.diff.files_2_dirs_1"-- NODE --
 id="sdc.config.diff.files_2_dirs_2"-- NODE --
java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_bn_IN.xml
 id="sdc.config.diff.files_2_dirs_1"-- NODE --
 id="sdc.config.diff.files_2_dirs_2"-- NODE --
[...]

Expected results:

			<trans-unit id="ssmchildsubs.jsp.unsubscribe">
(only once)

For 2., just file names should be shown, no --NODE-- output.

Additional info:

The xpath in step 2. is defined as

$ rpm -qf /usr/bin/xpath
perl-XML-XPath-1.13-8.fc11.noarch

Comment 1 Miroslav Suchý 2012-03-19 12:32:26 UTC
Done is spacewalk.git commit a8a8c37

Comment 2 Miroslav Suchý 2012-03-19 12:36:08 UTC
Cherrypicked to satellite.git as 75f4354

Comment 5 Clifford Perry 2012-09-21 09:35:08 UTC
This issue is resolved with the release of RHN Satellite 5.5. 

As of September 20th 2012, RHN Satellite 5.5 has been generally available. 

Release Notes and other 5.5 documentation can be found here:

 https://access.redhat.com/knowledge/docs/Red_Hat_Network_Satellite/

The associated Errata for the 5.5 release are:

5.5 Satellite GA Errata
 - http://rhn.redhat.com/errata/RHEA-2012-1296.html

5.5 Upgrade Errata
 - http://rhn.redhat.com/errata/RHEA-2012-1298.html

5.5 RHN Proxy GA Errata
 - http://rhn.redhat.com/errata/RHEA-2012-1297.html

5.5 RHN Tools GA Errata
 - http://rhn.redhat.com/errata/RHEA-2012-1299.html

Regards,
Clifford
- Engineering Manager, Satellite


Note You need to log in before you can comment on or make changes to this bug.