Bug 533291 - Review Request: ruby-ffi - Foreign Function Interface package for Ruby
Summary: Review Request: ruby-ffi - Foreign Function Interface package for Ruby
Keywords:
Status: CLOSED DUPLICATE of bug 540996
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-11-05 21:50 UTC by Bryan Kearney
Modified: 2009-11-24 17:07 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-11-24 17:07:24 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Bryan Kearney 2009-11-05 21:50:46 UTC
Spec URL: http://bkearney.fedorapeople.org/ruby-ffi-spec
SRPM URL: http://bkearney.fedorapeople.org/ruby-ffi-0.5.2-1.fc11.src.rpm
Description: Ruby-ffi is a package which allows for ruby code to access C libraries without the need for writing messy ext code. The website for the library is http://wiki.github.com/ffi/ffi.

Koji Scratch Build F11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1791211
Koji Scratch Build F12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1791220

rpmlint is clean on the spec file, SRPM, and locally build RPMs.

Comment 1 Mamoru TASAKA 2009-11-06 06:26:55 UTC
Would you consider to create your srpm from gem?
It seems that 0.5.1 gem is available on the usual rubyforge gem
URL:
http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem .

If you have some reason to use git based 0.5.2 source, still it is
preferable that you create gem archive and install it. Note that
while I don't know if 0.5.2 is formally released or not, please
refer to Naming guideline:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages

Comment 2 Bryan Kearney 2009-11-06 13:09:14 UTC
I did not read the guidelines [1] as requiring a gem. Has that changed? 0.5.2 is released, so I did believe I needed to refer to it as an alpha.

[1] https://fedoraproject.org/wiki/Packaging:Ruby

Comment 3 Mamoru TASAKA 2009-11-06 13:49:42 UTC
(In reply to comment #2)
> I did not read the guidelines [1] as requiring a gem. 

https://fedoraproject.org/wiki/Packaging:Ruby#Packaging_for_Gem_and_non-Gem_use
Some trouble happens when someone else want to use ffi gem on
Fedora and will try to import ffi gem package into Fedora.
In such cases, current Fedora guideline requests that gem based rpm
(i.e. rubygem-foo rpm) must be created first and non-gem support 
(i.e. ruby-foo) must be created as the subpackage of rubygem-foo.

gem has some additional usages (although many of them can be replaced
by rpm usage) and generally creating rpm from gem (if available) is preferable.

(In reply to comment #2)
> 0.5.2
> is released, 

If 0.5.2 is already released formally, please follow
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Post-Release_packages

Comment 4 Bryan Kearney 2009-11-06 21:06:14 UTC
Is the rubygem requirement a hard and fast rule? The current gem does not package the test library, and I think given the nature of this plugin having the ability to run the tests is more valuable then having a gem.

Plus, since I already had to patch this earlier in the process, i dont see how building from the gem allows us to add patches to the C code. Unless I pack and pack the gem.

-- bk

Comment 5 Bryan Kearney 2009-11-11 14:17:33 UTC
Just following up. this is against standard, but any issues with starting from a tarball and building a gem? This breaks the rubygem source _MUST_ be a gem, but it gets me the test code and test C libraries and I can build the gem from there.

-- bk

Comment 6 Bryan Kearney 2009-11-11 19:38:37 UTC
Here is an update. Changes made:

* Changed name to rubygem-ffi.
* I am still building from the source tarball which is against a "must" rule, but I build them gem from source and then install from it
* The version number is not changed since this is not a post release package. This is release 0.5.2. The github UI 
* rpmlint is clean on the spec and SRPM. One warning on the RPM:

[bkearney@localhost ~]$ rpmlint rpmbuild/RPMS/i586/rubygem-ffi-0.5.2-1.fc11.i586.rpm 
rubygem-ffi.i586: W: hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/ffi-0.5.2/.require_paths
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

* clean koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1802185

Updated SRPM: http://bkearney.fedorapeople.org/rubygem-ffi-0.5.2-1.fc11.src.rpm
Updated Spec File: http://bkearney.fedorapeople.org/rubygem-ffi.spec

Comment 7 Bryan Kearney 2009-11-17 00:26:19 UTC
Any feedback on the new spec file? Should I kill this bug and re-submit under the new name?

-- bk

Comment 8 Bryan Kearney 2009-11-24 17:07:24 UTC

*** This bug has been marked as a duplicate of bug 540996 ***


Note You need to log in before you can comment on or make changes to this bug.