Spec URL: http://sergiopr.fedorapeople.org/rst2pdf.spec SRPM URL: http://sergiopr.fedorapeople.org/rst2pdf-0.12.2-1.fc11.src.rpm Description: Tool for transforming reStructuredText to PDF using ReportLab
$ rpmlint rst2pdf.spec rst2pdf.spec: W: no-buildroot-tag 0 packages and 1 specfiles checked; 0 errors, 1 warnings. This warning can be ignored since we're using RPM versions greater than 4.6. $ rpmlint rst2pdf-0.12.2-1.fc11.src.rpm rst2pdf.src: W: no-buildroot-tag 1 packages and 0 specfiles checked; 0 errors, 1 warnings. As above. $ rpmlint rst2pdf-0.12.2-1.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines [x] Specfile name matches %{name}.spec [x] Package seems to meet Packaging Guidelines [x] Package successfully compiles and builds into binary RPMs on at least one supported architecture. Tested on: Fedora 11/x86_64; This is a noarch package [x] Rpmlint output: source RPM: see above binary RPM: empty [x] Package is not relocatable. [x] License in specfile matches actual License and meets Licensing Guidelines License: MIT [x] License file is included in %doc. [x] Specfile is legible and written in AE [x] Sourcefile in the Package is the same as provided in the mentioned Source SHA1SUM of Source: ce588073e4965b6b889be853ac84898b0abdb4e5 [x] Package compiles successfully [!] All build dependencies are listed in BuildRequires [-] Specfile handles locales properly there are no locales installed with this package [-] ldconfig called in %post and %postun if required [!] Package owns directorys it creates [-] Package requires other packages for directories it uses. [x] Package does not list a file more than once in the %files listing [x] %files section includes %defattr and permissions are set properly [x] %clean section is there and contains rm -rf %{buildroot} [x] Macros are consistently used [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage [x] Program runs properly without files listed in %doc [-] Header files are in a -devel package [-] Static libraries are in a -static package [-] Package requires pkgconfig if .pc files are present [-] .so-files are put into a -devel subpackage [-] Subpackages include fully versioned dependency for the base package [-] Any libtool archives (*.la) are removed [-] contains desktop file (%{name}.desktop) if it is a GUI application [!] Package does not own files or directories owned by other packages. [x] %{buildroot} is removed at beginning of %install [-] Filenames are encoded in UTF-8 === SUGGESTED ITEMS === [x] Package contains latest upstream version [x] Package does not include license text files separate from upstream. [-] non-English translations for description and summary [x] Package builds in mock Tested on: F11/x86_64 [x] Package should compile and build into binary RPMs on all supported architectures. tested build with koji [x] Program runs [-] Scriptlets must be sane, if used. [-] pkgconfig (*.pc) files are placed in a -devel package [-] require package providing a file instead of the file itself no files outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin are required === Python Specific === [x] Python egg is built from source. [x] Python egg does not download any dependencies during the build process [x] egg-info files are included in the package [-] installs using easy_install -m so it won't conflict with the main package this is no compat package [-] one of the packages contains a default version that is usable via "import MODULE" with no prior setup. there no multiple versions of this package [x] A package which is used by another package via an egg interface should provide egg info. Found issues: * Please remove the unneccessary comment in the first line * Please change the project URL to http://rst2pdf.googlecode.com/. * The program actually seems to require python-pygments, but the package doesn't. * Please run any install commands with the -p attribute to preserve timestamps * Please be more specific with listing files in the %files-section * Running the program does output some warnings: $ rst2pdf README /usr/lib/python2.6/site-packages/reportlab/pdfgen/canvas.py:17: DeprecationWarning: the md5 module is deprecated; use hashlib instead import md5 /usr/lib64/python2.6/site-packages/uniconvertor/app/utils/locale_utils.py:9: DeprecationWarning: The popen2 module is deprecated. Use the subprocess module. from popen2 import popen2 Cannot list directory /home/dmaphy/.uniconvertor:[Errno 2] No such file or directory: '/home/dmaphy/.uniconvertor' ignoring it in font_path [WARNING] createpdf.py:2419 You are using Reportlab version 2.1. The suggested version is 2.3 or higher [WARNING] styles.py:489 Using a borderPadding list in style admonition with wordaxe <= 0.3.2 or Reportlab < 2.3. That is not supported, so it will probably look wrong Please report these to upstream if neccessary.
I think I've fixed everything in this new specfile. Spec URL: http://sergiopr.fedorapeople.org/rst2pdf.spec SRPM URL: http://sergiopr.fedorapeople.org/rst2pdf-0.12.2-2.fc12.src.rpm The warning are related with reportlab version being < 2.3, not directly with rst2pdf
Just a small addition to the %files-section: %files %defattr(-,root,root,-) %doc CHANGES.txt Contributors.txt LICENSE.txt README.txt doc/manual.pdf %{_bindir}/%{name} %{python_sitelib}/%{name}* %{_mandir}/man1/* The %{name} macros are important to make sure no files other than the ones delivered with your package are affected. (See check point "Package does not own files or directories owned by other packages." in the list above.). The %{python_sitelib}-line actually was okay, but the %{name} macro is a bit more elegant. Before you import your Specfile to CVS, please add those macros. Anything else is okay now. The package is approved.
New Package CVS Request ======================= Package Name: rst2pdf Short Description: Tool for transforming reStructuredText to PDF Owners: sergiopr Branches: F-12 F-11 InitialCC:
CVS done.
Package Change Request ====================== Package Name: rst2pdf New Branches: el5 el6 Owners: sergiopr
Git done (by process-git-requests).