Bug 533489 - [Cisco 5.5 feat] Need scsi and libfc symbols to be added to whitelist_file
Summary: [Cisco 5.5 feat] Need scsi and libfc symbols to be added to whitelist_file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.4
Hardware: x86_64
OS: Linux
high
urgent
Target Milestone: beta
: 5.5
Assignee: Jon Masters
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks: 533941 557292
TreeView+ depends on / blocked
 
Reported: 2009-11-06 21:16 UTC by Venkata Siva Vijayendra Bhamidipati
Modified: 2010-03-30 07:17 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-30 07:17:20 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
fnic and libfc drivers built on rhel 5.4 GA, abi_check script and outputs, rpm -ivh kmod-fnic-1.1.0.182-0.x86_64.rpm output (1.92 MB, application/octet-stream)
2009-11-06 21:16 UTC, Venkata Siva Vijayendra Bhamidipati
no flags Details
533489-add-scsi_dma_map-and_scsi_dma_unmap-to-kABI.patch (10.44 KB, patch)
2009-12-01 18:26 UTC, Jon Masters
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2010:0178 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.5 kernel security and bug fix update 2010-03-29 12:18:21 UTC

Description Venkata Siva Vijayendra Bhamidipati 2009-11-06 21:16:17 UTC
Created attachment 367892 [details]
fnic and libfc drivers built on rhel 5.4 GA, abi_check script and outputs, rpm -ivh kmod-fnic-1.1.0.182-0.x86_64.rpm output

Description of problem:

****


Need to add following symbols to whitelist_file -

scsi_dma_map
fc_change_queue_depth
fc_lport_init
fc_get_host_port_state
fc_fabric_login
fc_rport_init
fc_exch_mgr_alloc
scsi_dma_unmap
fc_lport_config
fc_disc_init
fc_linkdown
fc_fabric_logoff
fc_exch_recv
fc_set_mfs
fc_elsct_init
fc_lport_destroy
fc_exch_mgr_free
fc_exch_mgr_reset
fc_change_queue_type
fc_exch_init
fc_linkup


Expected results:


Additional info:  

Note

You need to log in before you can comment on or make changes to this bug.


Version-Release number of selected component (if applicable):

fnic version 1.1.0.182 fnic.ko and libfc.ko attached.


How reproducible:

Steps to Reproduce:
1.Run driver disk ABI tester (abi_check.py) on fnic.ko

Actual results:
Getting ABI violation on the above listed symbols. The fnic.ko driver calls these functions directly, and all of them except two are exported by libfc.ko (also attached). The two functions scsi_dma_map and scsi_dma_unmap are called by fnic but are picked from scsi modules.

Running abi_check.py on libfc gives no complaints.

Upon building an rpm out of libfc and fnic, and trying to install the rpm using rpm -ivh, rpm complains about the scsi symbols alone. All outputs, the fnic.ko, libfc.ko and the abi_check.py script used, are attached in a single tgz file.


Additional info:

Comment 2 Jon Masters 2009-12-01 18:26:53 UTC
Created attachment 375148 [details]
533489-add-scsi_dma_map-and_scsi_dma_unmap-to-kABI.patch

Comment 6 Chris Ward 2009-12-03 14:27:03 UTC
@Cisco

We need to confirm that there is third-party commitment to 
test for the resolution of this request during the RHEL 5.5 
Beta Test Phase before we can approve it for acceptance 
into the release.

RHEL 5.5 Beta Test Phase is expected to begin around February
2010.

In order to avoid any unnecessary delays, please post a 
confirmation as soon as possible, including the contact 
information for testing engineers.

Any additional information about alternative testing variations we 
could use to reproduce this issue in-house would be appreciated.

Comment 8 Venkata Siva Vijayendra Bhamidipati 2009-12-04 00:07:28 UTC
The Cisco QA contact is Anthony Kent <antkent>.

We plan to test fnic/libfc driver disks for RHEL 5.5

Comment 11 Chris Ward 2010-02-11 10:05:49 UTC
~~ Attention Customers and Partners - RHEL 5.5 Beta is now available on RHN ~~

RHEL 5.5 Beta has been released! There should be a fix present in this 
release that addresses your request. Please test and report back results 
here, by March 3rd 2010 (2010-03-03) or sooner.

Upon successful verification of this request, post your results and update 
the Verified field in Bugzilla with the appropriate value.

If you encounter any issues while testing, please describe them and set 
this bug into NEED_INFO. If you encounter new defects or have additional 
patch(es) to request for inclusion, please clone this bug per each request
and escalate through your support representative.

Comment 12 Chris Ward 2010-03-05 13:01:14 UTC
@Cisco,

Please provide a test status / results update for this request as soon as possible. Thanks!

Comment 13 Venkata Siva Vijayendra Bhamidipati 2010-03-06 02:12:39 UTC
Hi Mike!

I tried the rpm install and none of the above symbols show up anymore, which is good, but I still see errors for these symbols -


[root@localhost rpms]# rpm -ivh kmod-fnic-0.0.1.40830M.ET.vbhamidi-1.x86_64.rpm
Preparing...                ########################################### [100%]
   1:kmod-fnic              ########################################### [100%]
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_vport_setlink
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_exch_mgr_add
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_cpu_mask
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_lport_logo_resp
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_elsct_send
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_frame_alloc_fill
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol _fc_frame_alloc
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_lport_flogi_resp
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol libfc_vport_create
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_vport_setlink
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_exch_mgr_add
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_cpu_mask
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_lport_logo_resp
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_elsct_send
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_frame_alloc_fill
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol _fc_frame_alloc
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol fc_lport_flogi_resp
WARNING: /lib/modules/2.6.18-190.el5/kernel/drivers/scsi/fcoe/fcoe.ko needs unknown symbol libfc_vport_create
[root@localhost rpms]# uname -a
Linux localhost.localdomain 2.6.18-190.el5 #1 SMP Mon Feb 22 19:13:18 EST 2010 x86_64 x86_64 x86_64 GNU/Linux
[root@localhost rpms]# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 5.5 Beta (Tikanga)
[root@localhost rpms]#
[root@localhost rpms]# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 5.5 Beta (Tikanga)
[root@localhost rpms]# rpm -qlp kmod-fnic-0.0.1.40830M.ET.vbhamidi-1.x86_64.rpm
/bin/fcc
/lib/modules/2.6.18-190.el5
/lib/modules/2.6.18-190.el5/extra
/lib/modules/2.6.18-190.el5/extra/fnic
/lib/modules/2.6.18-190.el5/extra/fnic/fnic.ko
/lib/modules/2.6.18-190.el5/extra/libfc
/lib/modules/2.6.18-190.el5/extra/libfc/libfc.ko
[root@localhost rpms]#


We do not package fcoe.ko, as can be seen in the above rpm -qlp output. The above messages show up as a result of depmod that is run as part of the rpm installation. However, these symbols required by fcoe.ko are again libfc symbols, so these must be added to the kabi whitelist as well.

Comment 14 Mike Christie 2010-03-07 01:51:28 UTC
(In reply to comment #13)
> installation. However, these symbols required by fcoe.ko are again libfc
> symbols, so these must be added to the kabi whitelist as well.    

fcoe.ko is techprevied for the life of RHEL 5. No one is going to use this in a production environment in RHEL 5. As a result I thought we were saying that we only cared about

- in tree fcoe.ko (care about for testing but not support) and in tree fnic.ko.
- out of tree fnic.ko. In this case fcoe.ko can be broken like above.

Comment 16 Abhijeet Joglekar 2010-03-08 05:47:29 UTC
yes, that's right, for 5.5 as long as the libfc symbols that fnic uses are added to the kabi, that should be good enough.

For 5.5, if we don't run into any libfc issues, the rpm for out-of-kernel fnic that we will package will only contain fnic and use the in-kernel libfc.

Comment 22 Andrius Benokraitis 2010-03-17 13:59:24 UTC
Vijay - in regard to your comment 13, these symbols will never be whitelisted since the fcoe.ko module will be constantly rebased and updated. Please create a new bugzilla for 5.6 that will request these be entered in the greylist file (which is new).

Comment 24 Venkata Siva Vijayendra Bhamidipati 2010-03-17 19:31:31 UTC
Hi Andrius!

I've logged in bugzilla 574557 for greylisting the above symbols..

Regards,
Vijayendra.

Comment 26 errata-xmlrpc 2010-03-30 07:17:20 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html


Note You need to log in before you can comment on or make changes to this bug.